Multiproc bug #177
Merged
Multiproc bug #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
mgkwill
requested review from
joyeshmishra,
ysingh7,
PhilippPlank and
awintel
mgkwill
added
1-bug
2 tasks
PhilippPlank
approved these changes
Feb 11, 2022
joyeshmishra
approved these changes
Feb 11, 2022
|
Thanks @PhilippPlank & @joyeshmishra |
mgkwill
added a commit
to mgkwill/lava
that referenced
this pull request
Feb 15, 2022
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
joyeshmishra
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Address review comments Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Improve mnist tutorial (#147) * Minor: Removed a divide by zero warning from the fixed point LIF ProcessModel Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Improved to MNIST end-to-end tutorial - uses fixed point bit-accurate ProcessModels for LIF and Dense - resets internal neural state of all LIF neurons - these changes are needed to make the pre-trained networks parameters work, because the network was trained with these assumptions Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post code review @awintel and @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post code review @awintel and @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post re-review by @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> Co-authored-by: PhilippPlank <32519998+PhilippPlank@users.noreply.github.com> * Check process lineage before join (#177) Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Add NxSDKRuntimeService Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Fix unit test, linting Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Remove comments Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Handle nxsdk import exception Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Fix indentation issue Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Uncomment board.run in nc proc model Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Address review, rework NxSdkRuntime Service Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com> * Fix unit tests, merge with main Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Remove nc/ports.py again Remove commented code in compiler.py Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Update comments logging Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Update test Utils method name and document Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Update test name and docs for nxsdkruntimeservice Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Update docstrings for RuntimeService Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Update logging Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> * Remove unneeded logging import Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com> Co-authored-by: Risbud, Sumedh <sumedh.risbud@intel.com> Co-authored-by: PhilippPlank <32519998+PhilippPlank@users.noreply.github.com> Co-authored-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #176
Objective of pull request: Fix Multiprocessing AssertionError: can only join a child process
Pull request checklist
Your PR fulfills the following requirements:
pyb) passes locallypyb -E unit) or (python -m unittest) passes locallyPull request type
Please check your PR type:
What is the current behavior?
packages/lava/magma/runtime/message_infrastructure/multiprocessing.py", line 79, in stop
actor.join()
File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/multiprocessing/process.py", line 147, in join
assert self._parent_pid == os.getpid(), 'can only join a child process'
AssertionError: can only join a child process
What is the new behavior?
Does this introduce a breaking change?