-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NxSDKRuntimeService #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
* Minor: Removed a divide by zero warning from the fixed point LIF ProcessModel Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Improved to MNIST end-to-end tutorial - uses fixed point bit-accurate ProcessModels for LIF and Dense - resets internal neural state of all LIF neurons - these changes are needed to make the pre-trained networks parameters work, because the network was trained with these assumptions Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post code review @awintel and @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post code review @awintel and @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> * Post re-review by @phstratmann Signed-off-by: Risbud, Sumedh <sumedh.risbud@intel.com> Co-authored-by: PhilippPlank <32519998+PhilippPlank@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
mgkwill
added
area: magma/runtime
Issues with something in lava/magma/runtime
area: magma/compiler
Issues with something in lava/magma/compiler
labels
Feb 15, 2022
2 tasks
mgkwill
requested review from
awintel,
srrisbud,
PhilippPlank,
ysingh7 and
joyeshmishra
February 15, 2022 22:16
mgkwill
commented
Feb 15, 2022
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Add docstrings everywhere. |
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
NxSDKRuntimeService does not meet class naming standards. Change to NxSdkRuntimeService. Same everywhere for NxSDK. |
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
mgkwill
commented
Feb 15, 2022
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
joyeshmishra
previously requested changes
Feb 16, 2022
awintel
reviewed
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before approving or requesting changes I need some fundamental architectural questions clarified.
Signed-off-by: Marcus G K Williams <168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
mgkwill
dismissed
joyeshmishra’s stale review
February 24, 2022 00:20
Old review. Please look at update.
Remove commented code in compiler.py Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
joyeshmishra
approved these changes
Feb 24, 2022
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
Signed-off-by: Marcus G K Williams <Marcus G K Williams 168222+mgkwill@users.noreply.github.com>
ysingh7
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: magma/compiler
Issues with something in lava/magma/compiler
area: magma/runtime
Issues with something in lava/magma/runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #181
Objective of pull request: Create NxSDKRuntimeService
Pull request checklist
Your PR fulfills the following requirements:
pyb
) passes locallypyb -E unit
) or (python -m unittest
) passes locallyPull request type
Please check your PR type:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?