Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Epochstorage migrator hot fix #1630

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

oren-lava
Copy link
Collaborator

@oren-lava oren-lava commented Aug 14, 2024

Description

Closes: #XXXX

The fix included a small migrator fix and adding old deleted migrators back to our code


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@oren-lava oren-lava self-assigned this Aug 14, 2024
@oren-lava oren-lava changed the title Epochstorage migrator hot fix fix: Epochstorage migrator hot fix Aug 14, 2024
Copy link

Test Results

2 167 tests  ±0   2 167 ✅ ±0   25m 11s ⏱️ -56s
  144 suites +1       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 535dc18. ± Comparison against base commit 1bd1d53.

@Yaroms Yaroms merged commit 26a8fad into main Aug 14, 2024
29 of 31 checks passed
@Yaroms Yaroms deleted the epochstorage-migrator-hot-fix branch August 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants