fix incorrect types of pointers (#465)

* cast handle back to uv_async_t before deleting * change unique_ptr type to const char[]
laverdet · May 20, 2024 · d00be92 · d00be92
1 parent 3f13eca
commit d00be92
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/isolate/scheduler.cc b/src/isolate/scheduler.cc
@@ -137,7 +137,7 @@ UvScheduler::UvScheduler(IsolateEnvironment& env) :
 
 UvScheduler::~UvScheduler() {
 	uv_close(reinterpret_cast<uv_handle_t*>(uv_async), [](uv_handle_t* handle) {
-		delete handle;
+		delete reinterpret_cast<uv_async_t*>(handle);
 	});
 }
 

diff --git a/src/module/isolate_handle.cc b/src/module/isolate_handle.cc
@@ -523,7 +523,7 @@ auto IsolateHandle::CreateSnapshot(ArrayRange script_handles, MaybeLocal<String>
 
 	// Create the snapshot
 	StartupData snapshot {};
-	unique_ptr<const char> snapshot_data_ptr;
+	unique_ptr<const char[]> snapshot_data_ptr;
 	shared_ptr<ExternalCopy> error;
 	{
 		Isolate* isolate;