Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/
isolate_handle.cc
:snapshot.data
, which is allocated by V8 asnew char[]
(snapshot.cc:546) is owned bysnapshot_data_ptr
, which is of typeunique_ptr<const char>
=>delete
is called upon destruction,delete[]
should be called instead=> changed the type of the unique_ptr to reflect this
2/
scheduler.cc
:uv_async
is allocated asuv_async_t
(128 B) but deleted asuv_handle_t
(96 B)=> added a cast back from
uv_handle_t*
touv_async_t*
before deletingTechnically, these situations are UB, but practically they don't cause any issues. They came up as a result of running the test suite with ASan which doesn't complain anymore after this trivial fix.