-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to socketio_v4 #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketio_v4 is a fork of socketio to avoid conflicting with the socketio namespace https://pypi.org/project/python-socketio-v4/
19 tasks
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Aug 28, 2024
reverts #124746 and updates the lib instead changelog: lawtancool/pyControl4@v1.1.0...v1.1.3 Note that there is no release yet, see lawtancool/pyControl4#32
19 tasks
Tested on my Home Assistant instance with Control4, works fine |
Thanks |
Thanks for the PR @bdraco, made it really fast to implement this fix! |
mib1185
pushed a commit
to mib1185/homeassistant-core
that referenced
this pull request
Aug 28, 2024
* Revert "Disable control4 integration (home-assistant#124746)" This reverts commit 16dd6b1. * Restore control4 integration reverts home-assistant#124746 and updates the lib instead changelog: lawtancool/pyControl4@v1.1.0...v1.1.3 Note that there is no release yet, see lawtancool/pyControl4#32 * Apply suggestions from code review
Gigatrappeur
pushed a commit
to Gigatrappeur/ha-core
that referenced
this pull request
Aug 28, 2024
* Revert "Disable control4 integration (home-assistant#124746)" This reverts commit 16dd6b1. * Restore control4 integration reverts home-assistant#124746 and updates the lib instead changelog: lawtancool/pyControl4@v1.1.0...v1.1.3 Note that there is no release yet, see lawtancool/pyControl4#32 * Apply suggestions from code review
iloveicedgreentea
pushed a commit
to iloveicedgreentea/core
that referenced
this pull request
Sep 4, 2024
* Revert "Disable control4 integration (home-assistant#124746)" This reverts commit 16dd6b1. * Restore control4 integration reverts home-assistant#124746 and updates the lib instead changelog: lawtancool/pyControl4@v1.1.0...v1.1.3 Note that there is no release yet, see lawtancool/pyControl4#32 * Apply suggestions from code review
JakeMartin-ICL
pushed a commit
to JakeMartin-ICL/home-assistant
that referenced
this pull request
Sep 21, 2024
* Revert "Disable control4 integration (home-assistant#124746)" This reverts commit 16dd6b1. * Restore control4 integration reverts home-assistant#124746 and updates the lib instead changelog: lawtancool/pyControl4@v1.1.0...v1.1.3 Note that there is no release yet, see lawtancool/pyControl4#32 * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socketio_v4 is a fork of socketio to avoid
conflicting with the socketio namespace
https://pypi.org/project/python-socketio-v4/