Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to socketio_v4 #32

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Switch to socketio_v4 #32

merged 1 commit into from
Aug 28, 2024

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Aug 28, 2024

socketio_v4 is a fork of socketio to avoid
conflicting with the socketio namespace

https://pypi.org/project/python-socketio-v4/

socketio_v4 is a fork of socketio to avoid
conflicting with the socketio namespace

https://pypi.org/project/python-socketio-v4/
bdraco added a commit to home-assistant/core that referenced this pull request Aug 28, 2024
reverts #124746 and updates the lib instead

changelog: lawtancool/pyControl4@v1.1.0...v1.1.3

Note that there is no release yet, see lawtancool/pyControl4#32
@lawtancool
Copy link
Owner

Tested on my Home Assistant instance with Control4, works fine

@lawtancool lawtancool merged commit ed4e8dc into lawtancool:master Aug 28, 2024
3 of 4 checks passed
@bdraco
Copy link
Contributor Author

bdraco commented Aug 28, 2024

Thanks

@bdraco bdraco deleted the socketio_v4 branch August 28, 2024 05:29
@lawtancool
Copy link
Owner

Thanks for the PR @bdraco, made it really fast to implement this fix!

mib1185 pushed a commit to mib1185/homeassistant-core that referenced this pull request Aug 28, 2024
* Revert "Disable control4 integration (home-assistant#124746)"

This reverts commit 16dd6b1.

* Restore control4 integration

reverts home-assistant#124746 and updates the lib instead

changelog: lawtancool/pyControl4@v1.1.0...v1.1.3

Note that there is no release yet, see lawtancool/pyControl4#32

* Apply suggestions from code review
Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Aug 28, 2024
* Revert "Disable control4 integration (home-assistant#124746)"

This reverts commit 16dd6b1.

* Restore control4 integration

reverts home-assistant#124746 and updates the lib instead

changelog: lawtancool/pyControl4@v1.1.0...v1.1.3

Note that there is no release yet, see lawtancool/pyControl4#32

* Apply suggestions from code review
iloveicedgreentea pushed a commit to iloveicedgreentea/core that referenced this pull request Sep 4, 2024
* Revert "Disable control4 integration (home-assistant#124746)"

This reverts commit 16dd6b1.

* Restore control4 integration

reverts home-assistant#124746 and updates the lib instead

changelog: lawtancool/pyControl4@v1.1.0...v1.1.3

Note that there is no release yet, see lawtancool/pyControl4#32

* Apply suggestions from code review
JakeMartin-ICL pushed a commit to JakeMartin-ICL/home-assistant that referenced this pull request Sep 21, 2024
* Revert "Disable control4 integration (home-assistant#124746)"

This reverts commit 16dd6b1.

* Restore control4 integration

reverts home-assistant#124746 and updates the lib instead

changelog: lawtancool/pyControl4@v1.1.0...v1.1.3

Note that there is no release yet, see lawtancool/pyControl4#32

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants