Skip to content

Commit

Permalink
Merge pull request #34 from laxmanpokhrel/dev
Browse files Browse the repository at this point in the history
Dev
  • Loading branch information
laxmanpokhrel committed Jul 2, 2024
2 parents 699dd5b + b797ad7 commit fa0b1b6
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 13 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ yarn-error.log*

.vscode/*
test.ts
lib/
lib/*
lib
6 changes: 2 additions & 4 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
# Ignore source files
src/
*.js
*.ts
src/*
src

# Ignore development tools and configuration files
node_modules/
.git/
.editorconfig
.eslintrc
tsconfig.json
.github
.husky
.vscodes
Expand Down
4 changes: 2 additions & 2 deletions .release/config.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"versionUpgradeType": "major",
"versionUpgradeType": "patch",
"releaseType": "--latest"
}
}
5 changes: 1 addition & 4 deletions .release/release-notes.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
# Changes
- With changed github workflow
- version dependency warning solve
- Subpath import of @xmanscript/utils
- version name changed
- remove tsconfig from .npmgnore
2 changes: 1 addition & 1 deletion src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ function useForm({
);
}
// form submission success
setFormState(prev => ({ ...prev, isSubmitionSuccess: true }));
setFormState(prev => ({ ...prev, isSubmitionSuccess: true, isSubmitionError: false, submitionError: null }));
}
} catch (error: any) {
// set submition status
Expand Down
2 changes: 1 addition & 1 deletion todo.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
[x]- track the formNames to prevent dublicate "formName"
[x]- provide the validation approach that the hook uses to custom validation schela along with the values
[x]- warn on leaving or reloading page if form submission status is not successful
[]- add config to add values from context when form mounts. rest of the logic is same but when component mounts we have to check if the config in true, if true then we shuld initialize the values to the that value.
[]- add config to add values from context when form mounts. rest of the logic is same but when component mounts we have to check if the config in true, if true then we should initialize the values to the that value.

0 comments on commit fa0b1b6

Please sign in to comment.