Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Gatsby v2 to v3 and Its Dependencies Also #1767

Merged
merged 14 commits into from Apr 18, 2021
Merged

Upgraded Gatsby v2 to v3 and Its Dependencies Also #1767

merged 14 commits into from Apr 18, 2021

Conversation

adithyaakrishna
Copy link
Member

@adithyaakrishna adithyaakrishna commented Apr 6, 2021 •
edited

Signed-off-by: Adithya Krishna aadithya794@gmail.com

Description

This PR Fixes #1699 and also Fixes #1782

Notes for Reviewers

  • Upgraded Gatsby from v2 to v3
  • Upgraded Its Dependencies and Plugins Also
  • Updated to gatsby-plugin-image
  • Updated LFX Foundation Logo to .svg and Centered the Image
  • Updated gatsby-cli from v3.2.0 to v3.3.0
  • Created Two Commands in Make File, make outdated and make update for npm outdated and npm update respectively

Signed commits

  • Yes, I signed my commits.

@adithyaakrishna
Upgraded Gatsby v2 to v3 and Its Dependencies Also
b1b091c 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 6, 2021

🚀 Preview for commit b1b091c at: https://606cc2d3e9eec700ba23d821--layer5ng.netlify.app

@l5io
Copy link
Contributor

l5io commented Apr 6, 2021

🚀 Preview for commit b1b091c at: https://606cc306b8017a0085ad438e--layer5ng.netlify.app

@leecalcote
Copy link
Member

@Nikhil-Ladha I wonder if we're accidentally triggering preview deploy builds more than once.

@leecalcote leecalcote requested a review from a team April 7, 2021 02:47
@leecalcote leecalcote added the kind/chore Necessary task label Apr 7, 2021
@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha I wonder if we're accidentally triggering preview deploy builds more than once.

Nope, the thing is the action triggers on a edit as well, and due to that we are getting multiple previews even without adding a commit.
Like, in this case the commit msg was edited after the PR was opened, so another preview was created.
Shall, I update the workflow remove the trigger on edit?

Nikhil-Ladha
Nikhil-Ladha reviewed Apr 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Nikhil-Ladha
Nikhil-Ladha reviewed Apr 7, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@l5io
Copy link
Contributor

l5io commented Apr 7, 2021

🚀 Preview for commit b75bc3d at: https://606dd83a1f01cb009fdc2e58--layer5ng.netlify.app

@Tanuj22
Copy link
Member

Tanuj22 commented Apr 7, 2021

@adithyaakrishna the DCO is failing

@adithyaakrishna
Upgraded to gatsby-plugin-image and Updated Graphql Queries
992294c 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Removed Outdated and Update Commands
ac44792 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Revert "Removed Outdated and Update Commands"
89844fe 
This reverts commit b75bc3d.

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Updated Makefile
cd4efae 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna adithyaakrishna force-pushed the upgrade/adithyaakrishna/#1699-GatsbyV2-V3 branch from 79d96b2 to cd4efae Compare April 7, 2021 16:22
@adithyaakrishna
Copy link
Member Author

@adithyaakrishna the DCO is failing

Sorry, had updated the makefile through GitHub itself, I've resolved it now :)

@l5io
Copy link
Contributor

l5io commented Apr 7, 2021

🚀 Preview for commit cd4efae at: https://606dde408379dd007cb366f9--layer5ng.netlify.app

@l5io
Copy link
Contributor

l5io commented Apr 7, 2021

🚀 Preview for commit cd4efae at: https://606dde9209799f0c68c657cb--layer5ng.netlify.app

@Nikhil-Ladha
Copy link
Contributor

Few places, where the image is broken:

  • Home page, news section
  • Meshery page, at the bottom (image switcher)
  • Images are not aligned properly (i.e in the center) in blogs and news pages.

@Nikhil-Ladha
Copy link
Contributor

Also, you have not updated the gatsby-config.js file to use the gatsby-plugin-image, I think that will require some tweaking as well.

@Nikhil-Ladha
Copy link
Contributor

Few places, where the image is broken:

  • Home page, news section
  • Meshery page, at the bottom (image switcher)
  • Images are not aligned properly (i.e in the center) in blogs and news pages.

I think the issue with the position of the image in blogs and news is because you have not updated the Card component with <GatsbyImage>.
Also, do check if you have updated all the places where we are using gatsby-image to use the updated component.

@adithyaakrishna
Copy link
Member Author

adithyaakrishna commented Apr 8, 2021 •
edited

Few places, where the image is broken:

  • Home page, news section
  • Meshery page, at the bottom (image switcher)
  • Images are not aligned properly (i.e in the center) in blogs and news pages.

I think the issue with the position of the image in blogs and news is because you have not updated the Card component with <GatsbyImage>.
Also, do check if you have updated all the places where we are using gatsby-image to use the updated component.

@Nikhil-Ladha Sorry I had missed those sections while checking, Will work on it and send a commit soon :)

Also there are some conflicts, which will also be resolved along with it

@leecalcote
Copy link
Member

Potentially, a very short demo in tomorrow's community meeting, @adithyaakrishna?

@leecalcote
Copy link
Member

Or in Monday's Websites meeting if time doesn't permit on tomorrow's agenda.

@adithyaakrishna
Copy link
Member Author

Sure @leecalcote , Would Monday be good ? as its related to websites also

@adithyaakrishna adithyaakrishna mentioned this pull request Apr 13, 2021
Closed
@leecalcote leecalcote linked an issue Apr 17, 2021 that may be closed by this pull request
Bump Gatsby CLI from version 3.2.0 to 3.3.0 #1791
Closed
@leecalcote leecalcote mentioned this pull request Apr 17, 2021
Closed
@adithyaakrishna
Copy link
Member Author

Yes @Nikhil-Ladha
I'm working on the images thing, I'm facing one problem, if I do some changes, .svg files are visible and if I do not .png files are available. So I had a discussion with @Tanuj22 and he had said .svg aren't supported by gatsby-image APIs.
So I'm trying some workarounds for it 😶

@adithyaakrishna
Fixes .svg Image Rendering
4f3560a 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Fixes Issue layer5io#1782
7537d06 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Merge branch 'master' of github.com:adithyaakrishna/layer5 into upgra…
30eed2c 
…de/adithyaakrishna/layer5io#1699-GatsbyV2-V3

Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Updated GraphQL Queries
d6d0f46 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha There's another issue linked to the PR i.e. #1791
Should I update the gatsby-cli version from 3.2.0 to 3.3.0 ?

@adithyaakrishna
Fixed RelatedPosts Query
48d9bb3 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 17, 2021

🚀 Preview for commit 48d9bb3 at: https://607b467e1d8fad1b4d5fa7cb--layer5ng.netlify.app

@l5io
Copy link
Contributor

l5io commented Apr 17, 2021

🚀 Preview for commit 48d9bb3 at: https://607b49a3815f4ccfec6c64b3--layer5ng.netlify.app

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha There's another issue linked to the PR i.e. #1791
Should I update the gatsby-cli version from 3.2.0 to 3.3.0 ?

Yes, please.

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha Okay sure 🚀

@adithyaakrishna
Upgraded gatsby-cli to v3.3.0
90f4fcc 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 18, 2021

🚀 Preview for commit 90f4fcc at: https://607bdc1339599bb958421bf2--layer5ng.netlify.app

@l5io
Copy link
Contributor

l5io commented Apr 18, 2021

🚀 Preview for commit 90f4fcc at: https://607bdc37d842d030d0ecb8ca--layer5ng.netlify.app

Nikhil-Ladha
Nikhil-Ladha reviewed Apr 18, 2021
View reviewed changes
gatsby-config.js Outdated Show resolved Hide resolved
@adithyaakrishna
Updated gatsby-config.js
865f83f 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@adithyaakrishna adithyaakrishna mentioned this pull request Apr 18, 2021
Closed
@adithyaakrishna
Updated gatsby-plugin-image
aebe885 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 18, 2021

🚀 Preview for commit 865f83f at: https://607c12b91178813e2b0ef393--layer5ng.netlify.app

@adithyaakrishna
Removed Related-Posts
cedf8f5 
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Nikhil-Ladha
Nikhil-Ladha approved these changes Apr 18, 2021
View reviewed changes
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great update @adithyaakrishna 👏

@adithyaakrishna
Copy link
Member Author

Looks good. Great update @adithyaakrishna 👏

Thank You @Nikhil-Ladha 🎉

@l5io
Copy link
Contributor

l5io commented Apr 18, 2021

🚀 Preview for commit cedf8f5 at: https://607c16508b9c675a87aa06cd--layer5ng.netlify.app

@Nikhil-Ladha Nikhil-Ladha merged commit 4b6e659 into layer5io:master Apr 18, 2021
@adithyaakrishna adithyaakrishna deleted the upgrade/adithyaakrishna/#1699-GatsbyV2-V3 branch April 18, 2021 12:11
@adithyaakrishna adithyaakrishna restored the upgrade/adithyaakrishna/#1699-GatsbyV2-V3 branch April 18, 2021 15:14
@adithyaakrishna adithyaakrishna mentioned this pull request Jul 19, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikhil-Ladha Nikhil-Ladha Nikhil-Ladha approved these changes

@Tanuj22 Tanuj22 Awaiting requested review from Tanuj22

Assignees
No one assigned
Labels
kind/chore Necessary task
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump Gatsby CLI from version 3.2.0 to 3.3.0 [Programs] Logo not centered Upgrade to Gatsby v3
5 participants
@adithyaakrishna @l5io @leecalcote @Nikhil-Ladha @Tanuj22