New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] - NPM Dependency Caching and Lighthouse Audit Action #2957
[CI] - NPM Dependency Caching and Lighthouse Audit Action #2957
Conversation
# https://github.com/treosh/lighthouse-ci-action | ||
uses: treosh/lighthouse-ci-action@v9 | ||
with: | ||
urls: ${{ steps.netlify.outputs.url }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nikhil-Ladha is there any way using which we can share outputs from other workflows? I am a bit stuck on that here 😶
CC @Chadha93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but what output are you referring to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nikhil-Ladha Is there any way where we can extract the l5io bot output which comments the preview URL for the workflow here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the find-comment
action, only if you have the PR number for which the workflow is running.
Or, if that's not possible then another way is to save the deploy URL as an artifact in the preview-site
workflow and then download that artifact here and get the URL from it.
If the first one is feasible, then that is preferred.
🚀 Preview for commit 27a1d1a at: https://62c34e83617947399fca538d--layer5.netlify.app |
Oh! This is exciting. 😃 |
I was thinking about this PR, and wondered is it actually beneficial to have? We need an upgrade to v4, which has been pending a long time on me and if someone can take that up, that should help us make things faster (if not much). Because, the limitation here is GitHub actions env, which is very basic and no matter the big improvement locally, when it comes to GitHub actions the performance improvement becomes negligible. |
@Nikhil-Ladha I can take this up as I had worked on the v2 to v3 thing last year(#1767), but this week might be a bit difficult as our team at Red Hat is on an office trip and I am in Pune as of now. I can take this up the following one if that would be fine CC @leecalcote |
Sure, you can update us regarding it next week 👍🏼 |
🚀 Preview for commit 6112b01 at: https://62e84a592f372b3635635b9f--layer5.netlify.app |
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
6112b01
to
6962a9b
Compare
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
🚀 Preview for commit 96f5f51 at: https://62e8ec715ed8aa2fd73cac22--layer5.netlify.app |
🚀 Preview for commit 62418fb at: https://62ea00c04c8fb35442ba88b9--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots's of great stuff here by @adithyaakrishna 💪. Good to go @Nikhil-Ladha @adithyaakrishna?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the docker.png file that you have added is not needed
@@ -11,6 +11,7 @@ module.exports = { | |||
twitterUsername: "@layer5", | |||
}, | |||
flags: { | |||
PARALLEL_SOURCING: true, | |||
FAST_DEV: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is enabled by default in gatsbyv4. Not needed
I doubt, the lighthouse.yml workflow is still incomplete |
@Nikhil-Ladha Yes, this is not yet complete, I am trying to work on a solution to find the preview links every time a code is pushed and this workflow is something we use at Red Hat as well. So I thought to implement something similar here |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
Can we expect an update here @adithyaakrishna ? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
Description
This PR fixes #2773
Notes for Reviewers
Ref: https://github.com/adithyaakrishna/adithyaakrishna.github.io/actions - Only the two most recent action triggers
Signed commits