Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] - NPM Dependency Caching and Lighthouse Audit Action #2957

Conversation

adithyaakrishna
Copy link
Member

@adithyaakrishna adithyaakrishna commented Jul 4, 2022

Description

This PR fixes #2773

Notes for Reviewers

Ref: https://github.com/adithyaakrishna/adithyaakrishna.github.io/actions - Only the two most recent action triggers
Screenshot 2022-07-05 at 1 10 32 AM

  • Added Lighthouse Audit GitHub Action - WIP

Signed commits

  • Yes, I signed my commits.

@adithyaakrishna adithyaakrishna self-assigned this Jul 4, 2022
@adithyaakrishna adithyaakrishna added kind/enhancement New feature or request type/ci Continuous Integration pr/hold Do not merge this PR labels Jul 4, 2022
# https://github.com/treosh/lighthouse-ci-action
uses: treosh/lighthouse-ci-action@v9
with:
urls: ${{ steps.netlify.outputs.url }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikhil-Ladha is there any way using which we can share outputs from other workflows? I am a bit stuck on that here 😶

CC @Chadha93

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, but what output are you referring to here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nikhil-Ladha Is there any way where we can extract the l5io bot output which comments the preview URL for the workflow here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the find-comment action, only if you have the PR number for which the workflow is running.
Or, if that's not possible then another way is to save the deploy URL as an artifact in the preview-site workflow and then download that artifact here and get the URL from it.

If the first one is feasible, then that is preferred.

@l5io
Copy link
Contributor

l5io commented Jul 4, 2022

🚀 Preview for commit 27a1d1a at: https://62c34e83617947399fca538d--layer5.netlify.app

@leecalcote
Copy link
Member

Oh! This is exciting. 😃

@Nikhil-Ladha
Copy link
Contributor

I was thinking about this PR, and wondered is it actually beneficial to have?
For us dependency installation hardly takes a minute, it is the site build that takes most of the time. And even after caching the npm dependencies that are not going to reduce.

We need an upgrade to v4, which has been pending a long time on me and if someone can take that up, that should help us make things faster (if not much). Because, the limitation here is GitHub actions env, which is very basic and no matter the big improvement locally, when it comes to GitHub actions the performance improvement becomes negligible.

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha I can take this up as I had worked on the v2 to v3 thing last year(#1767), but this week might be a bit difficult as our team at Red Hat is on an office trip and I am in Pune as of now. I can take this up the following one if that would be fine

CC @leecalcote

@Nikhil-Ladha
Copy link
Contributor

Nikhil-Ladha commented Jul 19, 2022

Sure, you can update us regarding it next week 👍🏼

@l5io
Copy link
Contributor

l5io commented Aug 1, 2022

🚀 Preview for commit 6112b01 at: https://62e84a592f372b3635635b9f--layer5.netlify.app

Adithya Krishna added 15 commits August 2, 2022 14:37
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@adithyaakrishna adithyaakrishna force-pushed the feat/adithyaakrishna/ci-npm-caching branch from 6112b01 to 6962a9b Compare August 2, 2022 09:08
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@l5io
Copy link
Contributor

l5io commented Aug 2, 2022

🚀 Preview for commit 96f5f51 at: https://62e8ec715ed8aa2fd73cac22--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 3, 2022

🚀 Preview for commit 62418fb at: https://62ea00c04c8fb35442ba88b9--layer5.netlify.app

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots's of great stuff here by @adithyaakrishna 💪. Good to go @Nikhil-Ladha @adithyaakrishna?

Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the docker.png file that you have added is not needed

@@ -11,6 +11,7 @@ module.exports = {
twitterUsername: "@layer5",
},
flags: {
PARALLEL_SOURCING: true,
FAST_DEV: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enabled by default in gatsbyv4. Not needed

@Nikhil-Ladha
Copy link
Contributor

Lots's of great stuff here by @adithyaakrishna 💪. Good to go @Nikhil-Ladha @adithyaakrishna?

I doubt, the lighthouse.yml workflow is still incomplete

@adithyaakrishna
Copy link
Member Author

@Nikhil-Ladha Yes, this is not yet complete, I am trying to work on a solution to find the preview links every time a code is pushed and this workflow is something we use at Red Hat as well. So I thought to implement something similar here

Ref: https://github.com/patternfly/patternfly-elements/blob/main/.github/workflows/visual-regression.yml#L65

@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Oct 1, 2022
@deepeshaburse deepeshaburse added issue/remind and removed issue/stale Issue has not had any activity for an extended period of time labels Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Nikhil-Ladha
Copy link
Contributor

Can we expect an update here @adithyaakrishna ?

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 16, 2022
@stale
Copy link

stale bot commented Dec 21, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/remind issue/stale Issue has not had any activity for an extended period of time kind/enhancement New feature or request pr/hold Do not merge this PR type/ci Continuous Integration
Development

Successfully merging this pull request may close these issues.

[CI] Improve build and deploy time
6 participants