refresh redirection dissabled #5126
Conversation
Signed-off-by: balagowda <balagowda9483@gmail.com>
|
🚀 Preview for commit a479ebd at: https://6554d23a21c5da1a6c9369a2--layer5.netlify.app |
src/reusecore/Search/index.js
Outdated
| @@ -40,7 +40,7 @@ const SearchBox = ({ | |||
| debounceTimeout={500} | |||
| onChange={(e) => handleChange(e)} | |||
| placeholder="Search..." | |||
| autoFocus | |||
| // autoFocus | |||
There was a problem hiding this comment.
One thing to say here though @balagowda, if we comment autoFocus then one inconsistency we can observe here while searching and typing for any particular blog is that typing a word is struggling here a bit. You can compare this with the current state of layer5.io/blog here. Can we do something so that our refresh redirection issue as well as this typing inconsistency both get resolve @balagowda ?
There was a problem hiding this comment.
I'll look into this
|
🚀 Preview for commit ab31d16 at: https://6555975d820c1932ddc43e91--layer5.netlify.app |
Signed-off-by: balagowda <balagowda9483@gmail.com>
|
🚀 Preview for commit e841eb3 at: https://6555c5d16ca7334bedfb775b--layer5.netlify.app |
|
🚀 Preview for commit d761ec6 at: https://6556f89c0140ac54bb502b0e--layer5.netlify.app |
|
@abhijeetgauravm is there anything needs to be change?? |
|
@balagowda +1 with @abhijeetgauravm's point. The search bar on the blog page doesn't seem to focus if the search input is cleared. Consider typing a word and clearing it to search for another one, does losing the focus of the search bar and again needing to click the search bar give a good UX? Thoughts? |
Signed-off-by: balagowda <balagowda9483@gmail.com>
|
🚀 Preview for commit 186679b at: https://65577bbad3a2173538f0e610--layer5.netlify.app |
|
I hope this resolve the problem @Mohith234 , @abhijeetgauravm |
|
🚀 Preview for commit 49c1aca at: https://65577e8c2dea093593a01f17--layer5.netlify.app |
|
Hey @balagowda Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
|
🚀 Preview for commit 4ba4926 at: https://655b4a8743f2597b6d55edbf--layer5.netlify.app |
|
is there anything need to be change?? @abhijeetgauravm @Mohith234 |
|
🚀 Preview for commit 7fac8e8 at: https://655c99d35df8ab786551e9dc--layer5.netlify.app |
leecalcote
requested review from
AbiodunVlad
and removed request for
Mohith234
Looks good to me @balagowda Thanks for the contribution! // @Mohith234 @sudhanshutech |
|
🚀 Preview for commit 9e9d766 at: https://6561de00593b11236c9a50ed--layer5.netlify.app |
|
🚀 Preview for commit 828c788 at: https://6566a44ada425b04f458ea1a--layer5.netlify.app |
|
🚀 Preview for commit 085a305 at: https://6567c7d51eaeb12fade1b8a2--layer5.netlify.app |
|
Thanks for the work that you put into this review, @Mohith234 and @abhijeetgauravm. Way to stick with it, @balagowda 👍 |
|
Late reviewer....sorry about that. |
on refresh homepage redirection to integrations section is resolved
This PR fixes #5124
Notes for Reviewers
Signed commits