Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh redirection dissabled #5126

Merged
merged 12 commits into from
Nov 29, 2023
Merged

refresh redirection dissabled #5126

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a479ebd
refresh redirection dissabled
balagowda Nov 15, 2023
ab31d16
Merge branch 'layer5io:master' into refresh
balagowda Nov 16, 2023
e841eb3
error correction on focus
balagowda Nov 16, 2023
d761ec6
Merge branch 'layer5io:master' into refresh
balagowda Nov 17, 2023
186679b
Merge branch 'layer5io:master' into refresh
balagowda Nov 17, 2023
49c1aca
updated search focus and refresh redirection
balagowda Nov 17, 2023
4ba4926
Merge branch 'layer5io:master' into refresh
balagowda Nov 20, 2023
7fac8e8
Merge branch 'layer5io:master' into refresh
balagowda Nov 21, 2023
9e9d766
Merge branch 'layer5io:master' into refresh
balagowda Nov 25, 2023
828c788
Merge branch 'layer5io:master' into refresh
balagowda Nov 29, 2023
9c44900
Merge branch 'master' into refresh
leecalcote Nov 29, 2023
085a305
Merge branch 'master' into refresh
leecalcote Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reusecore/Search/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const SearchBox = ({
debounceTimeout={500}
onChange={(e) => handleChange(e)}
placeholder="Search..."
autoFocus
// autoFocus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to say here though @balagowda, if we comment autoFocus then one inconsistency we can observe here while searching and typing for any particular blog is that typing a word is struggling here a bit. You can compare this with the current state of layer5.io/blog here. Can we do something so that our refresh redirection issue as well as this typing inconsistency both get resolve @balagowda ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this

/>
<Button aria-label="search icon">
<FaSearch />
Expand Down
2 changes: 1 addition & 1 deletion src/sections/Meshery/Meshery-integrations/Integration.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const HoneycombGrid = styled.div`
&:hover {
opacity: 0.8;
box-shadow: 0px 0px 6px -2px rgb(60, 73, 79);
}
}
}

.selected {
Expand Down