-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Career page #783
Career page #783
Conversation
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
Deploy preview for layer5ng ready! Built with commit af05a97 |
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
@Tanuj22 @Nikhil-Ladha can you review my pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But few improvements can be done:
- The
What is Layer5
section, can be moved above the video. - In the opportunities section, all the internship cards can be moved below the internship subheading and a new
Full-Time Opportunities
subheading can be created and the other cards can be put below it. - The design of the cards for the programs can be improved a bit, like the border can be made a bit more prominent.
- Also,
See our careers page...
line can be removed as we are already on the careers page
Also, @leecalcote any text or info that can be added for Full time opportunities like internship ?
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
@Nikhil-Ladha ,let me know if there is any content to be added under the full time sections. For the time being i have just added it without any description |
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
Made the changes you requested @Nikhil-Ladha . Tho i am not able to understand what you mean by making the borders more prominent. |
Signed-off-by: Vinayak Sharma <vinayaksh42@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Nice work 🚀 @vinayaksh42
Signed-off-by: Vinayak Sharma vinayaksh42@gmail.com
Description
Migration of careers page from previous layer5 website to layer5-ng
previouse website ---> layer5-ng
This PR fixes #710
Notes for Reviewers
I have made some ui changes while migrating from the previous layer5 Website to the current layer5-ng website according to my own thought process. So kindly guide on that and suggest any changes if needed
Signed commits