workshop page improved #820

s-pratyush · 2020-09-25T09:51:20Z

Description

This PR fixes #783

Notes for Reviewers

Yes, I signed my commits.

welcome · 2020-09-25T09:51:22Z

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

netlify · 2020-09-25T09:51:29Z

Deploy preview for layer5io ready!

Built with commit 99513ec

https://deploy-preview-820--layer5io.netlify.app

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

Neilblaze · 2020-09-25T21:04:35Z

@Pratyush-Saxena nice work!

Before I approve the PR, I am suggesting some changes on the above.

In mobile view, the workshops.svg image is at second position & it's dimension is also minimized. Sharing a screenshot for reference. This needs to be fixed.

Shift the workshops.svg image at the first position & increase it's size.
It'll be great if you add media queries to neglect the workshops.svg image for mobile view! [Optional]

In your deploy preview of the workshop page, add a padding of 50px between the starting row & the workshop text.
Fix the position of the forklift in the newsletter section.

Rest LGTM 👍

Neilblaze

Remove this two auto-generated files! [.gitpod.Dockerfile & .gitpod.yml]

Neilblaze

Reset the Ruby version to 2.7.0

Neilblaze · 2020-09-25T21:17:50Z

_includes/collections/workshops.html

+        <img
+          class="activator"
+          src="{{workshop.img}}"
+          style="


Shift the inline css to a fixed .css file.

@Neilblaze so in which file should i shift this styling

Shift the inline css to a fixed .css file.

or i think it should be just removed because ...i tried so and found nothing being affected..

if the above css does nothing then feel free to remove it, if not then try shifting this to assets/css/<filename.css>

Neilblaze · 2020-09-25T21:21:50Z

Also, adding to the above,

#783 is already resolved!
#773 looks perfect 👌

s-pratyush · 2020-09-26T06:04:35Z

@Pratyush-Saxena nice work!

Before I approve the PR, I am suggesting some changes on the above.

In mobile view, the workshops.svg image is at second position & it's dimension is also minimized. Sharing a screenshot for reference. This needs to be fixed.

Shift the workshops.svg image at the first position & increase it's size.
It'll be great if you add media queries to neglect the workshops.svg image for mobile view! [Optional]

In your deploy preview of the workshop page, add a padding of 50px between the starting row & the workshop text.

Fix the position of the forklift in the newsletter section.

Rest LGTM

@Neilblaze i can make all the changes you requested except one thing that making workshop.svg display at the top in mobile view which is not possible coz these cards are displayed using a sequestial condition

Neilblaze · 2020-09-26T10:56:27Z

@Pratyush-Saxena do one thing. Break the sequence. Keep the workshop.svg image just below the "Workshop" text. Then start the sequence from the row present just below the workshop.svg . Make sure to keep a distinct gap / padding between them.

s-pratyush · 2020-09-26T11:00:20Z

@Pratyush-Saxena do one thing. Break the sequence. Keep the workshop.svg image just below the "Workshop" text. Then start the sequence from the row present just below the workshop.svg . Make sure to keep a distinct gap / padding between them.

That's what I have already done.....but the point is that how could i do that for mobile view and tab view separately

Neilblaze · 2020-09-26T11:36:13Z

See if you do what I said, then the sequence will be like this -

Now I think it should be clear!

s-pratyush · 2020-09-26T12:06:41Z

Yeah I guess now it's pretty much clear to me .

Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com>

Neilblaze · 2020-09-26T19:50:39Z

_includes/collections/workshops.html

    <img
      src="/assets/images/workshops/workshops.svg"
-      style="overflow: hidden;"
+      style="overflow: hidden;max-height:80vh"


add margin-top: 25px; to this line

Neilblaze · 2020-09-26T19:56:17Z

Umm maybe it'll look better if you remove the top workshop illustration & keep the bottom workshop illustration as it is, since keeping same illustration twice in a single page might not look that good.

Amazing work by the way @Pratyush-Saxena 👌
Make the quick change & I'll approve the PR!

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in>

Neilblaze

LGTM 👍
Nice work 🎉

Make sure to remove the gitpod files, since they are unnecessary auto-generated files.

s-pratyush · 2020-09-27T15:03:40Z

LGTM
Nice work

Make sure to remove the gitpod files, since they are unnecessary auto-generated files.

where do you find these files..pls let me know

Neilblaze · 2020-09-27T15:09:41Z

Here

s-pratyush · 2020-09-27T15:24:48Z

Here

@Neilblaze they were deleted in commit 371a02f alredy and are now not a part of my base repository

Neilblaze · 2020-09-27T15:27:37Z

Oh I see, I forgot to upstream. Ok then it's good to go!

s-pratyush · 2020-09-28T06:21:33Z

Oh I see, I forgot to upstream. Ok then it's good to go!

when will it get merge?

Nikhil-Ladha · 2020-09-28T09:18:11Z

Which issues are being fixed here? I see the link in the description points to a merged PR, please correct that and also don't mention issue names in the commit subject. Also, is the issue #773 fixed?

leecalcote

Looking good, @Pratyush-Saxena! 💥

welcome · 2020-09-28T18:26:10Z

Thanks for your contribution to the Layer5 community! 🎉

⭐ Please star the project if you have yet to do so.

leecalcote · 2020-09-28T18:26:35Z

Whoo-hoo, @Pratyush-Saxena! 🎈

Thank you, @Neilblaze 👍

s-pratyush mentioned this pull request Sep 25, 2020

Fix the styling of Workshops page! #792

Closed

Pratyush-Saxena added 5 commits September 25, 2020 13:59

gitpod file added

371a02f

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

#773 resolve

887ce1d

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

issue #792 resolved

f02870d

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

issue #783 resolved

08e9975

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

Signed-off-by:Pratyush Saxena <saxena18prats.com>

be6629c

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in> Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com> Signed-off-by: Pratyush-Saxena <saxena18prats@gmail.com>

Neilblaze suggested changes Sep 25, 2020

View reviewed changes

Neilblaze reviewed Sep 25, 2020

View reviewed changes

requested changes made

9289f83

Signed-off-by: Pratyush-Saxena <52444607+Pratyush-Saxena@users.noreply.github.com>

Neilblaze reviewed Sep 26, 2020

View reviewed changes

resolving #783

99513ec

Signed-off-by: Pratyush-Saxena <pratyush.19b131054@abes.ac.in>

s-pratyush requested a review from Neilblaze September 27, 2020 08:47

Neilblaze approved these changes Sep 27, 2020

View reviewed changes

leecalcote approved these changes Sep 28, 2020

View reviewed changes

leecalcote merged commit a7b0a77 into layer5io:master Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

workshop page improved #820

workshop page improved #820

s-pratyush commented Sep 25, 2020 •

edited

welcome bot commented Sep 25, 2020

netlify bot commented Sep 25, 2020 •

edited

Neilblaze commented Sep 25, 2020 •

edited

Neilblaze left a comment

Neilblaze left a comment

Neilblaze Sep 25, 2020

s-pratyush Sep 26, 2020

s-pratyush Sep 26, 2020 •

edited

Neilblaze Sep 26, 2020

Neilblaze commented Sep 25, 2020

s-pratyush commented Sep 26, 2020 •

edited

Neilblaze commented Sep 26, 2020 •

edited

s-pratyush commented Sep 26, 2020

Neilblaze commented Sep 26, 2020

s-pratyush commented Sep 26, 2020

Neilblaze Sep 26, 2020

Neilblaze commented Sep 26, 2020

Neilblaze left a comment

s-pratyush commented Sep 27, 2020 •

edited

Neilblaze commented Sep 27, 2020

s-pratyush commented Sep 27, 2020 •

edited

Neilblaze commented Sep 27, 2020

s-pratyush commented Sep 28, 2020

Nikhil-Ladha commented Sep 28, 2020

leecalcote left a comment

welcome bot commented Sep 28, 2020

leecalcote commented Sep 28, 2020

workshop page improved #820

workshop page improved #820

Conversation

s-pratyush commented Sep 25, 2020 • edited

welcome bot commented Sep 25, 2020

netlify bot commented Sep 25, 2020 • edited

Neilblaze commented Sep 25, 2020 • edited

Neilblaze left a comment

Choose a reason for hiding this comment

Neilblaze left a comment

Choose a reason for hiding this comment

Neilblaze Sep 25, 2020

Choose a reason for hiding this comment

s-pratyush Sep 26, 2020

Choose a reason for hiding this comment

s-pratyush Sep 26, 2020 • edited

Choose a reason for hiding this comment

Neilblaze Sep 26, 2020

Choose a reason for hiding this comment

Neilblaze commented Sep 25, 2020

s-pratyush commented Sep 26, 2020 • edited

Neilblaze commented Sep 26, 2020 • edited

s-pratyush commented Sep 26, 2020

Neilblaze commented Sep 26, 2020

s-pratyush commented Sep 26, 2020

Neilblaze Sep 26, 2020

Choose a reason for hiding this comment

Neilblaze commented Sep 26, 2020

Neilblaze left a comment

Choose a reason for hiding this comment

s-pratyush commented Sep 27, 2020 • edited

Neilblaze commented Sep 27, 2020

s-pratyush commented Sep 27, 2020 • edited

Neilblaze commented Sep 27, 2020

s-pratyush commented Sep 28, 2020

Nikhil-Ladha commented Sep 28, 2020

leecalcote left a comment

Choose a reason for hiding this comment

welcome bot commented Sep 28, 2020

leecalcote commented Sep 28, 2020

s-pratyush commented Sep 25, 2020 •

edited

netlify bot commented Sep 25, 2020 •

edited

Neilblaze commented Sep 25, 2020 •

edited

s-pratyush Sep 26, 2020 •

edited

s-pratyush commented Sep 26, 2020 •

edited

Neilblaze commented Sep 26, 2020 •

edited

s-pratyush commented Sep 27, 2020 •

edited

s-pratyush commented Sep 27, 2020 •

edited