Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] run a performance test using profile name #6

Merged
merged 6 commits into from
Aug 4, 2021

Conversation

DelusionalOptimist
Copy link
Contributor

Signed-off-by: Rudraksh Pareek rudrakshpareek3601@gmail.com

Description

This PR fixes #

Notes for Reviewers
Supply a profile name, this action will deploy the service mesh specified in it and run the performance test.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
@leecalcote leecalcote added area/performance Performance management area/tests Testing / quality assurance labels Aug 4, 2021
@leecalcote
Copy link
Member

When the user specifies a specific mesh, does the action also only deploy the adapter specific to the mesh in question?

@leecalcote leecalcote merged commit dd42345 into layer5io:master Aug 4, 2021
@DelusionalOptimist
Copy link
Contributor Author

DelusionalOptimist commented Aug 5, 2021

@leecalcote when running a test by giving a profile name, no, it deploys all the adapters.
The reason: we need to start meshery once to connect with the provider and retrieve the mesh specified in the performance profile. Since we aren't sure which mesh will need to be deployed initially, we deploy all of the adapters.
Immediate solutions to this that I can think of:

  • Ask for the service mesh to use in the workflow itself. (Similar to SMI conformance action)
  • Start meshery without any adapters, retrieve the test config from cloud, add the appropriate adapter to meshery's current context and then restart meshery : /
  • Any others.... ?

On the other hand, if we run a performance test by spcifying a file containing the performance profile, only the appropriate adapter will be deployed but this has yet to be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance management area/tests Testing / quality assurance
Development

Successfully merging this pull request may close these issues.

None yet

2 participants