Previously PinLayout was setting the view's frame. This was breaking the view's tranform #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the view's tranform. By setting the view's center and bounds we set the frame of the non-transformed view, and this keeps the view's transform. So view's transforms won't be affected/altered anymore by PinLayout. For people not using transforms, this should be a non-breaking change. If someone is using transforms with PinLayout, this may change the behaviour, although I think this will produce the expected results (ie, transforms not being affected/altered by layout).
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=========================================
+ Coverage 89.36% 90.37% +1%
=========================================
Files 33 34 +1
Lines 7554 6232 -1322
Branches 440 0 -440
=========================================
- Hits 6751 5632 -1119
+ Misses 796 600 -196
+ Partials 7 0 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting the view's center and bounds we set the frame of the non-transformed view, and this keeps the view's transform.
So view's transforms won't be affected/altered anymore by PinLayout.
For people not using transforms, this should be a non-breaking change. If someone is using transforms with PinLayout, this may change the behavior, although I think this will produce the expected results (ie, transforms not being affected/altered by layout).