Use make function instead of smart pointer constructor. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcaspers
suggested changes
Nov 15, 2016
| @@ -201,8 +201,8 @@ namespace QuantLib { | |||
|
|
|||
| MakeCms& MakeCms::withDiscountingTermStructure( | |||
| const Handle<YieldTermStructure>& discountingTermStructure) { | |||
| engine_ = boost::shared_ptr<PricingEngine>(new | |||
| DiscountingSwapEngine(discountingTermStructure)); | |||
| engine_ = boost::static_pointer_cast<PricingEngine>( | |||
There was a problem hiding this comment.
the static_pointer_cast should not be necessary?
There was a problem hiding this comment.
As engine_ is a boost::shared_ptr<PricingEngine> static_pointer_cast make explicit an implicit conversion with no run-time impact. I usually use the cast when I know the code must be compiled on different OS , because some compiler may complain about it.
There was a problem hiding this comment.
Ok, is it just to be 110% safe or did you actually see a compiler having problems with it? It would be interesting to know.
There was a problem hiding this comment.
It is to be 110% safe . I tested this on Windows VS and Centos 7 gcc 4.8.5 with no problem.
Can be removed .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.