boost 1.67 (beta 1) does not allow to register the same test case name multiple times #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Apr 3, 2018
| (i *LENGTH(oneDataValues))/nTestCases, | ||
| ((i+1)*LENGTH(oneDataValues))/nTestCases))); | ||
| } | ||
| #define N_TEST_CASES 5 |
There was a problem hiding this comment.
What was the problem here? Just curious.
There was a problem hiding this comment.
with the upcoming boost_1_67 release it is no longer possible that two test cases have the same name.
If no name is provided boost more or less takes the method name as internal test case name and due to the usage of boost::bind here all test cases within the for loop got the same internal name.
This changes with the usage of the preprocessor for loop. I was also considering to remove the test case split here and to get back to the old solution where we have had one test case running for multiple minutes.
There was a problem hiding this comment.
(And it's ok to keep the test cases split.)
lballabio
approved these changes
Apr 4, 2018
lballabio
pushed a commit
that referenced
this pull request
Apr 5, 2018
multiple times. Backported from #446.
lballabio
added a commit
that referenced
this pull request
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log Boost.Test v3.7 / boost 1.67:
Breaking changes: Adding test cases with the same name to the same test suite is reported as an error. This impacts template and parametrized test cases, as well as manually registered tests. Make sure you have no duplicate names.