Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button typing #247

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Fix button typing #247

merged 7 commits into from
Dec 22, 2021

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Dec 18, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
⚪ Ignored check: brands
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Monday)
✅ README.md exists
✅ Requirements validation
✅ HACS load check

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2021

This pull request introduces 1 alert when merging 0a45a58 into 51000b4 - view on LGTM.com

new alerts:

  • 1 for Unused import

@drc38
Copy link
Collaborator Author

drc38 commented Dec 18, 2021

@lbbrhzn looks like main issue was the tests.yaml python version. Is there any reason not to bump?

@drc38 drc38 requested a review from lbbrhzn December 18, 2021 06:03
@lbbrhzn
Copy link
Owner

lbbrhzn commented Dec 18, 2021

I guess we should use the same version as home assistant.

@drc38
Copy link
Collaborator Author

drc38 commented Dec 18, 2021

I guess we should use the same version as home assistant.

My HA info says Python 3.9.7 but the sensor entity uses the same typing notation here whereas the typing documentation says | was introduced at 3.10... I'm confused 😕

@drc38
Copy link
Collaborator Author

drc38 commented Dec 20, 2021

So looks like we're missing this import:
from __future__ import annotations
As discussed here

@lbbrhzn lbbrhzn merged commit 99ac061 into main Dec 22, 2021
@lbbrhzn lbbrhzn deleted the drc38-patch-14 branch December 22, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants