Corrected temperature in assignment of sta2_default

For #3151
lbl-srg · Nov 11, 2022 · 0c88d3f · 0c88d3f
1 parent b785c1d
commit 0c88d3f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo b/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo
@@ -21,16 +21,13 @@ model PartialEffectivenessNTU
 
   parameter Modelica.SIunits.HeatFlowRate Q_flow_nominal(fixed=use_Q_flow_nominal)
     "Nominal heat flow rate (positive for heat transfer from 1 to 2)"
-    annotation (Dialog(group="Nominal thermal performance",
-                       enable=use_Q_flow_nominal));
+    annotation (Dialog(group="Nominal thermal performance", enable=use_Q_flow_nominal));
   parameter Modelica.SIunits.Temperature T_a1_nominal(fixed=use_Q_flow_nominal)
-    "Nominal temperature at port a1"
-    annotation (Dialog(group="Nominal thermal performance",
-                       enable=use_Q_flow_nominal));
+    "Nominal temperature at port a1" annotation (Dialog(group="Nominal thermal performance",
+                                                        enable=use_Q_flow_nominal));
   parameter Modelica.SIunits.Temperature T_a2_nominal(fixed=use_Q_flow_nominal)
-    "Nominal temperature at port a2"
-    annotation (Dialog(group="Nominal thermal performance",
-                       enable=use_Q_flow_nominal));
+    "Nominal temperature at port a2" annotation (Dialog(group="Nominal thermal performance",
+                                                        enable=use_Q_flow_nominal));
 
   parameter Real eps_nominal(fixed=not use_Q_flow_nominal)
     "Nominal heat transfer effectiveness"
@@ -55,7 +52,7 @@ protected
      p=Medium1.p_default,
      X=Medium1.X_default[1:Medium1.nXi]) "Default state for medium 1";
   final parameter Medium2.ThermodynamicState sta2_default = Medium2.setState_pTX(
-     T=Medium1.T_default,
+     T=Medium2.T_default,
      p=Medium2.p_default,
      X=Medium2.X_default[1:Medium2.nXi]) "Default state for medium 2";
 
@@ -221,6 +218,12 @@ for <code>UA</code>.
 </html>", revisions="<html>
 <ul>
 <li>
+November 11, 2023, by Michael Wetter:<br/>
+Corrected wrong temperature in assignment of <code>sta2_default</code>.<br/>
+This is for
+<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3151\">Buildings, issue 3151</a>.
+</li>
+<li>
 February 25, 2021 by Baptiste Ravache:<br/>
 Added a warning for when Q_flow_nominal is specified with the wrong sign.
 </li>

diff --git a/Buildings/package.mo b/Buildings/package.mo
@@ -259,6 +259,18 @@ The following <b style=\"color:red\">critical errors</b> have been fixed (i.e.,
 that can lead to wrong simulation results):
 </p>
 <table class=\"releaseTable\" summary=\"summary\" border=\"1\" cellspacing=\"0\" cellpadding=\"2\" style=\"border-collapse:collapse;\">
+<tr><td colspan=\"2\"><b>Buildings.Fluid.HeatExchangers</b>
+    </td>
+</tr>
+<tr><td valign=\"top\">Buildings.Fluid.HeatExchangers.BaseClasses.PartialEffectivenessNTU
+    </td>
+    <td valign=\"top\">Corrected wrong temperature in assignment of <code>sta2_default</code>.
+                       For <code>Buildings.Media.Air</code> and <code>Buildings.Media.Water<code>
+                       this error does not affect the results.<br/>
+                       This is for
+                       <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3151\">Buildings, issue 3151</a>
+    </td>
+</tr>
 <tr><td colspan=\"2\"><b>Buildings.Examples</b>
     </td>
 </tr>