Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid.HeatExchangers.BaseClasses.PartialEffectivenessNTU has wrongly designed sta2_default #3151

Closed
RouvenZ opened this issue Nov 11, 2022 · 1 comment · Fixed by #3152
Closed

Comments

@RouvenZ
Copy link

RouvenZ commented Nov 11, 2022

Dear all,

within the file PartialEffectivenessNTU in the Fluid Package there seems to be an error in line 57, where it defines the default state for medium 2 sta2_default with the default temperature of medium 1 which (as not mentioned in the docu) I assume to be a typo:

final parameter Medium2.ThermodynamicState sta2_default = Medium2.setState_pTX(
T=Medium1.T_default,
p=Medium2.p_default,
X=Medium2.X_default[1:Medium2.nXi]) "Default state for medium 2";

As most default temperatures are defined at 20°C, I assume this has never had an impact. However, for compatibility reasons and designing new media, I assume this might cause problems.

Thanks for caring, have a nice weekend!

Cheers
Rouven

@mwetter
Copy link
Member

mwetter commented Nov 11, 2022

Thanks for reporting. I will correct it.
For Media.Air and Media.Water the temperature does not affect the thermodynamic properties, but it is nevertheless good to correct.

mwetter added a commit to ibpsa/modelica-ibpsa that referenced this issue Nov 11, 2022
mwetter added a commit that referenced this issue Nov 12, 2022
* Corrected temperature in assignment of sta2_default

For #3151
mwetter added a commit that referenced this issue Nov 12, 2022
* Corrected temperature in assignment of sta2_default

For #3151
mwetter added a commit that referenced this issue Nov 12, 2022
* Corrected temperature in assignment of sta2_default

For #3151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants