Correct assignment of sta2_default in PartialEffectivenessNTU (#3152)

* Corrected temperature in assignment of sta2_default For #3151
lbl-srg · Nov 12, 2022 · 765910d · 765910d
1 parent 5994b61
commit 765910d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo b/Buildings/Fluid/HeatExchangers/BaseClasses/PartialEffectivenessNTU.mo
@@ -54,7 +54,7 @@ protected
      p=Medium1.p_default,
      X=Medium1.X_default[1:Medium1.nXi]) "Default state for medium 1";
   final parameter Medium2.ThermodynamicState sta2_default = Medium2.setState_pTX(
-     T=Medium1.T_default,
+     T=Medium2.T_default,
      p=Medium2.p_default,
      X=Medium2.X_default[1:Medium2.nXi]) "Default state for medium 2";
 
@@ -220,6 +220,12 @@ for <code>UA</code>.
 </html>", revisions="<html>
 <ul>
 <li>
+November 11, 2023, by Michael Wetter:<br/>
+Corrected wrong temperature in assignment of <code>sta2_default</code>.<br/>
+This is for
+<a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3151\">Buildings, issue 3151</a>.
+</li>
+<li>
 February 25, 2021 by Baptiste Ravache:<br/>
 Added a warning for when Q_flow_nominal is specified with the wrong sign.
 </li>

diff --git a/Buildings/package.mo b/Buildings/package.mo
@@ -434,14 +434,23 @@ that can lead to wrong simulation results):
 <tr><td colspan=\"2\"><b>Buildings.Fluid.HeatExchangers</b>
     </td>
 </tr>
+<tr><td valign=\"top\">Buildings.Fluid.HeatExchangers.BaseClasses.PartialEffectivenessNTU
+    </td>
+    <td valign=\"top\">Corrected wrong temperature in assignment of <code>sta2_default</code>.
+                       For <code>Buildings.Media.Air</code> and <code>Buildings.Media.Water</code>
+                       this error does not affect the results.<br/>
+                       This is for
+                       <a href=\"https://github.com/lbl-srg/modelica-buildings/issues/3151\">Buildings, issue 3151</a>
+    </td>
+</tr>
 <tr><td valign=\"top\">Buildings.Fluid.HeatExchangers.DXCoils.AirCooled.MultiStage<br/>
                        Buildings.Fluid.HeatExchangers.DXCoils.AirCooled.SingleStage<br/>
                        Buildings.Fluid.HeatExchangers.DXCoils.AirCooled.VariableSpeed<br/>
                        Buildings.Fluid.HeatExchangers.DXCoils.WaterCooled.MultiStage<br/>
                        Buildings.Fluid.HeatExchangers.DXCoils.WaterCooled.SingleStage<br/>
                        Buildings.Fluid.HeatExchangers.DXCoils.WaterCooled.VariableSpeed<br/>
-   	                   Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.CoolingCapacityWaterCooled<br/>
-	                   Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.PartialCoolingCapacity
+                       Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.CoolingCapacityWaterCooled<br/>
+                       Buildings.Fluid.HeatExchangers.DXCoils.BaseClasses.PartialCoolingCapacity
 
     </td>
     <td valign=\"top\">Corrected performance calculation as a function of mass flow rates.<br/>