Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-needed start values in CDL.{Integer,Logical}.Change #2990

Closed
mwetter opened this issue May 3, 2022 · 3 comments · Fixed by #2992
Closed

Remove non-needed start values in CDL.{Integer,Logical}.Change #2990

mwetter opened this issue May 3, 2022 · 3 comments · Fixed by #2992
Assignees
@mwetter
Labels
OpenBuildingControl
Milestone
Release 9.0

Comments

@mwetter
Copy link
Member

mwetter commented May 3, 2022

Remove non-needed start values for

Controls/OBC/CDL/Integers/Change.mo
Controls/OBC/CDL/Logical/Change.mo

The blocks don't need a start value, and currently non-consistent start values are used.
@mwetter mwetter added this to the Release 9.0 milestone May 3, 2022
@mwetter mwetter self-assigned this May 3, 2022
@mwetter mwetter changed the title Remove non-needed start values Remove non-needed start values in CDL.{Integer,Logical}.Change May 3, 2022
@mwetter
Copy link
Member Author

mwetter commented May 3, 2022

The same change can be done to

Controls/OBC/CDL/Logical/Edge.mo
Controls/OBC/CDL/Logical/FallingEdge.mo

mwetter added a commit that referenced this issue May 3, 2022
@mwetter
Removed non-needed start values
cfb7820 
This is for #2990
@mwetter mwetter mentioned this issue May 3, 2022
Merged
@mwetter
Copy link
Member Author

mwetter commented May 4, 2022

With this change, Buildings.Examples.VAVReheat.Guideline36 and Buildings.ThermalZones.EnergyPlus_9_6_0.Examples.SmallOffice.Guideline36Winter are structurally singular in OCT.

@mwetter
Copy link
Member Author

mwetter commented May 6, 2022

Keeping a start value is better as it avoids the structurally singular system, which otherwise would need to be avoided by adding a pre block after the hysteresis in Buildings/Controls/OBC/ASHRAE/G36_PR1/TerminalUnits/Reheat/SystemRequests.mo, as shown here:
image

Keeping the parameters pre_u_start makes them consistent with the blocks in the Modelica Standard Library. Moreover, a similar Simulink block also requires providing an initial value.

However, for consistency with Logical.Change, in Integer.Change, the parameter y_start should be changed to pre_u_start. Then, all these blocks have a parameter pre_u_start.

mwetter added a commit that referenced this issue May 6, 2022
@mwetter
Changed parameter y_start to pre_u_start. Reverted other changes.
617be17 
For #2990
mwetter added a commit that referenced this issue May 9, 2022
@mwetter
Issue2990 cdl start value (#2992)
736f5e0 
* Corrected conversion script entries

This corrects wrong use of convertClass

* Removed non-needed start values

This is for #2990

* Changed parameter y_start to pre_u_start. Reverted other changes.

For #2990

* Updated release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwetter mwetter

Labels
OpenBuildingControl
Projects
None yet
Milestone
Release 9.0
Development

Successfully merging a pull request may close this issue.

Issue2990 cdl start value lbl-srg/modelica-buildings
1 participant
@mwetter