Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dp(start=dpValve_nominal/2) in PartialThreeWayValve #3231

Closed
mwetter opened this issue Feb 3, 2023 · 0 comments · Fixed by #3232 or #3246
Closed

Remove dp(start=dpValve_nominal/2) in PartialThreeWayValve #3231

mwetter opened this issue Feb 3, 2023 · 0 comments · Fixed by #3232 or #3246
Assignees

Comments

@mwetter
Copy link
Member

mwetter commented Feb 3, 2023

The model Buildings/Fluid/Actuators/BaseClasses/PartialThreeWayValve.mo is the only one where the start attribute of dp is modified. It is set to dp(start=dpValve_nominal/2). The two-way valves, and the fixed resistances, do not set this start value, and hence it remains at 0 as set here:

This issue is to remove the assignment, and test it across all models and tools using the master branch. If successful, it needs to be ported upstream to IBPSA. The motivation is to get consistency of the settings, and also because removing dp(start=dpValve_nominal/2) will lead on branch IBPSASync_issue1412_stateSelect_Tp, commit d361f82, the models Buildings.Examples.Tutorial.Boiler.System{3,4} to simulate with Optimica, which indicates that it better not be set (these models start with zero mass flow rate).

(The model Buildings.Examples.Tutorial.Boiler.System5 and higher still fail on branch IBPSASync_issue1412_stateSelect_Tp, as they do prior to removing the start value.)

@mwetter mwetter self-assigned this Feb 3, 2023
mwetter added a commit that referenced this issue Feb 3, 2023
mwetter added a commit that referenced this issue Feb 7, 2023
* Removed start value for dp

This is for #3231

* Updated reference results
@mwetter mwetter mentioned this issue Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant