Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect assert statement in Fluid.HeatPumps.EquationFitReversible #3664

Closed
AntoineGautier opened this issue Feb 15, 2024 · 1 comment
Closed

Incorrect assert statement in Fluid.HeatPumps.EquationFitReversible #3664

AntoineGautier opened this issue Feb 15, 2024 · 1 comment
Assignees
@AntoineGautier
Labels
bug
Milestone
Release 9.1.2

Comments

@AntoineGautier
Copy link
Contributor

Describe the bug

Inside the model Fluid.HeatPumps.EquationFitReversible the Assert block checks that the condition uMod<0 is met for non-reversible heat pumps.
The condition shall rather be uMod>=0, indicating off=0 or heating mode=+1 command.
@AntoineGautier AntoineGautier self-assigned this Feb 15, 2024
@mwetter mwetter added the bug label Feb 15, 2024
@mwetter
Copy link
Member

mwetter commented Feb 15, 2024 •
edited

Thanks for catching this. This is indeed a bug that is not caught by the configuration of the unit tests.
This will need to be updated on

  • maint_9.1.x
  • maint_10.0.x
  • master

@mwetter mwetter added this to the Release 9.1.2 milestone Feb 15, 2024
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode
85750e8 
For #3664
@mwetter mwetter mentioned this issue Apr 1, 2024
Closed
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode (main 9.1.x)
8d55bff 
For #3664
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode
83c1dbd 
For #3664
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode
b5a26c0 
For #3664
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode
3fc360e 
For #3664
mwetter added a commit that referenced this issue Apr 1, 2024
@mwetter
Corrected assertion for operating mode
27bd222 
For #3664
This was referenced Apr 1, 2024
Closed
Merged
mwetter added a commit that referenced this issue Apr 2, 2024
@mwetter @dhblum
@AntoineGautier @hcasperfu
Batch pr master (#3767)
c5fd934 
* Remove reference to network design data record in Combined.PartialBuildingTimeSeriesWithETS

* Renamed CDL.Logical.TrueHoldWithReset to TrueHold

For #3689

* Expand to full class names

* Refactored implementation to avoid infinite event iteration in OpenModelica

For #3754

* wrong variable description in Fluid.HeatExchangers

* corrected location of revisions in annotation

* Corrected assertion for operating mode

For #3664

---------

Co-authored-by: David Blum <dhblum@lbl.gov>
Co-authored-by: AntoineGautier <agautier@solamen.fr>
Co-authored-by: hcasperfu <hcasperfu@lbl.gov>
mwetter added a commit that referenced this issue Apr 2, 2024
@mwetter @dhblum
Batch pr maint 9.1.x (#3768)
d4eb6be 
* Corrected wrong parameter assignment in ChillerDXHeatingEconomizer (maint_9.1.x)

This corrects the wrong dimension, which OMEdit detects and triggers a warning

* Adjust hysteresis for heating

* Refactored implementation to avoid infinite event iteration in OpenModelica

For #3754

* Corrected assertion for operating mode (main 9.1.x)

For #3664

* Corrected assertion for operating mode

For #3664

* Refactored implementation to avoid infinite event iteration in OpenModelica

---------

Co-authored-by: David Blum <dhblum@lbl.gov>
@mwetter mwetter closed this as completed Apr 2, 2024
mwetter added a commit that referenced this issue Apr 3, 2024
@mwetter @dhblum
Batch pr maint 10.0.x (#3769)
955666b 
* Update hysteresis for heating

* Refactored implementation to avoid infinite event iteration in OpenModelica

For #3754

* Corrected assertion for operating mode

For #3664


* Refactored implementation to avoid infinite event iteration in OpenModelica

---------

Co-authored-by: David Blum <dhblum@lbl.gov>
mwetter added a commit that referenced this issue Apr 3, 2024
@mwetter
reversible heat pump assertion (maint_10.0.x) (#3766)
1b7fd5e 
* Corrected assertion for operating mode

For #3664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntoineGautier AntoineGautier

Labels
bug
Projects
None yet
Milestone
Release 9.1.2
Development

Successfully merging a pull request may close this issue.

Corrected assertion for operating mode lbl-srg/modelica-buildings
2 participants
@mwetter @AntoineGautier