Buildings.Controls.DemandResponse.Client model contains may generate infinite event iterations #3754
Comments
mwetter
added a commit
that referenced
this issue
Mar 29, 2024
mwetter
added a commit
that referenced
this issue
Mar 29, 2024
mwetter
added a commit
that referenced
this issue
Mar 29, 2024
This was referenced Mar 29, 2024
|
@AndreaBartolini : Thanks for reporting. This will be corrected through the above 3 pull requests. |
mwetter
added a commit
that referenced
this issue
Apr 2, 2024
* Remove reference to network design data record in Combined.PartialBuildingTimeSeriesWithETS * Renamed CDL.Logical.TrueHoldWithReset to TrueHold For #3689 * Expand to full class names * Refactored implementation to avoid infinite event iteration in OpenModelica For #3754 * wrong variable description in Fluid.HeatExchangers * corrected location of revisions in annotation * Corrected assertion for operating mode For #3664 --------- Co-authored-by: David Blum <dhblum@lbl.gov> Co-authored-by: AntoineGautier <agautier@solamen.fr> Co-authored-by: hcasperfu <hcasperfu@lbl.gov>
mwetter
added a commit
that referenced
this issue
Apr 2, 2024
* Corrected wrong parameter assignment in ChillerDXHeatingEconomizer (maint_9.1.x) This corrects the wrong dimension, which OMEdit detects and triggers a warning * Adjust hysteresis for heating * Refactored implementation to avoid infinite event iteration in OpenModelica For #3754 * Corrected assertion for operating mode (main 9.1.x) For #3664 * Corrected assertion for operating mode For #3664 * Refactored implementation to avoid infinite event iteration in OpenModelica --------- Co-authored-by: David Blum <dhblum@lbl.gov>
mwetter
added a commit
that referenced
this issue
Apr 3, 2024
* Update hysteresis for heating * Refactored implementation to avoid infinite event iteration in OpenModelica For #3754 * Corrected assertion for operating mode For #3664 * Refactored implementation to avoid infinite event iteration in OpenModelica --------- Co-authored-by: David Blum <dhblum@lbl.gov>
mwetter
added a commit
that referenced
this issue
Apr 3, 2024
* Refactored implementation to avoid infinite event iteration in OpenModelica For #3754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The model
Buildings.Controls.DemandResponse.Clientcontains a shorted loop that may generate infinite event iterations depending on the implementation of the event iteration made by the Modelica compiler.The details are discussed in the OpenModelica/OpenModelica#10992.
To Reproduce in OpenModelica
Steps to reproduce the behavior:
Buildings.Controls.DemandResponse.Examples.ClientLBNL90The simulation fails and the following message is shown:
Simulation terminated due to too many, i.e. 20, event iterations. This could either indicate an inconsistent system or an undersized limit of event iterations. The limit of event iterations can be specified using the runtime flag '–mei=<value>'.The model simulates in Dymola because the implementation of the Event Iteration in Dymola is slightly different from that of OpenModelica.
A possible solution to break the shorted loop is to add a little delay (e.g.
tsample/1000) in the transitiont1of theBuildings.Controls.DemandResponse.Clientmodel .Version
Modelica Buildings Library:
Version: 11.0.0 - SHA cf73e6f
Modelica simulation environment:
OpenModelica v1.23.0-dev-396-g9ae201ce92 (64-bit)
Operating system
win11 pro - 64 bit
Keep @casella in the loop...
The text was updated successfully, but these errors were encountered: