Issue2651 condensing boiler #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erguide file, added unit test results, other minor fixes
describing the efficiency of mod-con boilers with a table
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
reviewed
Oct 26, 2021
JayHuLBL
requested changes
Oct 26, 2021
|
@hcasperfu please also merge the latest master branch |
mwetter
approved these changes
Nov 9, 2021
|
@JayHuLBL : Please approve if the revisions address your review comment. |
Q_flow_nominal was removed because this value depends on the size of the equipment, so no default should be provided. The m_flow_nominal assignment is removed because it uses dT_nominal, which has been removed in a previous commit
mwetter
reviewed
Nov 9, 2021
JayHuLBL
reviewed
Nov 9, 2021
JayHuLBL
requested changes
Nov 9, 2021
|
@hcasperfu please see inline comments |
…rg/modelica-buildings into issue2651_condensingBoiler
JayHuLBL
approved these changes
Nov 9, 2021
hcasperfu
added a commit
that referenced
this pull request
Nov 10, 2021
In preparation, the usersguide is partially rewrote so that the description of equations correspond to the model text equation by equation. Some explanatory texts are also rearranged to improve clarity. Some redundant or duplicate documentation left behind in #2695 is cleaned out.
mwetter
added a commit
that referenced
this pull request
Nov 19, 2021
* improved the usersguide In preparation, the usersguide is partially rewrote so that the description of equations correspond to the model text equation by equation. Some explanatory texts are also rearranged to improve clarity. Some redundant or duplicate documentation left behind in #2695 is cleaned out. * implemented boiler correction The changes are very small and I suspect that it was caused by my using Ubuntu 20 instead of 18. But I am pushing it anyway so that it could be tested by someone else. * Revised documentation, removed trailing white spaces * Removed trailing white spaces Done by running for ff in Fluid/Boilers/*; do sed -e 's/ *$//g' -i Fluid/Boilers/BoilerPolynomial.mo; done; Co-authored-by: Michael Wetter <mwetter@lbl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A model is created to describe the efficiency of a boiler with both firing rate and inlet temperature. This moves the old
BoilerPolynomialtoBaseClasses.PartialBoiler. The latter is then extended to the newBoilerPolynomialandBoilerTable.This closes #2651.