Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unresolvable relationships from resource models #35

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Mar 4, 2024

Overview

The recent update to mu-cl-resources 1.23.0 includes some changes in the handling of undefined resource models.
This PR ensures that relationships pointing to undefined models are removed.
Specifically, the following relationships have been removed:

  • zitting
    • aanwezigen-bij-start
    • secretaris
    • voorzitter
  • behandeling-van-agendapunt
    • aanwezigen
    • secretaris
    • voorzitter
  • stemming
    • aanwezigen
    • onthouders
    • stemmers
    • tegenstanders
    • voorstanders
  • besluit
    • realisatie
  • versioned-agenda
    • editor-document
    • document-container
  • versioned-behandeling
    • editor-document
    • document-container
  • versioned-besluiten-lijst
    • editor-document
    • document-container
  • versioned-notulen
    • editor-document
    • document-container
  • published-resource
    • gebruiker
  • signed-resource
    • gebruiker
  • artikel
    • realisatie
  • bestuurseenheid
    • contactinfo
  • bestuursorgaan
    • wordt-samengesteld-door
    • bevat
    • bevat-bestuursfunctie
  • bestuursorgaan-classificatie-code
    • standaard-type
connected issues and PRs:

lblod/app-gelinkt-notuleren#178

How to test/reproduce

  • run mu project doc and observe that the generation of json:api docs executes without errors

Challenges/uncertainties

It seems that this application contains a lot of redundant resource definitions, copied over from GN, but unused in this application.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • no new deprecations

@elpoelma elpoelma added the bug Something isn't working label Mar 4, 2024
@abeforgit abeforgit merged commit 0376f12 into master Mar 5, 2024
@abeforgit abeforgit deleted the fix/remove-unresolvable-relationships branch March 5, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants