Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-edit focus keeps moving to different words after video playback is paused #131

Closed
MikeRidgway opened this issue Feb 1, 2018 · 7 comments
Assignees
Labels

Comments

@MikeRidgway
Copy link

... making it kind of hard to edit the word that you intended to edit as the keystroke you press will be applied to a different word by the time you press it.

@lborgman lborgman self-assigned this Feb 3, 2018
@lborgman lborgman added the bug label Feb 3, 2018
@lborgman
Copy link
Owner

lborgman commented Feb 3, 2018

Thanks @MikeRidgway , it looked like I stopped at the wrong place. I think I fixed it now (0.64.75).

Do you still see it?

@lborgman
Copy link
Owner

lborgman commented Feb 3, 2018

Hm, the bug is still there.

@lborgman
Copy link
Owner

lborgman commented Feb 4, 2018

But now it might be mostly gone. (I'm still hesitating to implement an FSM for this. Too many states. I must be thinking wrong somehow. 🤔)

@lborgman
Copy link
Owner

lborgman commented Feb 4, 2018

Hm, no. When I tested an hour ago it worked fine on my mobile, but now"play word" doesn't always start as it should. So there is a timing issue.

@lborgman
Copy link
Owner

lborgman commented Feb 4, 2018

Maybe I should say that at the bottom of this problem is the fact that the YouTube video player does not tell you when it has moved to the time you requested. So you have to loop and check to find out when it is ready. However this creates performance problems on a mobile if you do it too fast. And a bad UI if you do it too slow.

@MikeRidgway
Copy link
Author

MikeRidgway commented Feb 4, 2018 via email

@lborgman
Copy link
Owner

lborgman commented Feb 5, 2018

I think this is fixed now. It should be pretty stable. (Though there is one issue with starting to play word while already playing word. It should just restart playing the same word.)

@lborgman lborgman closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants