Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t compile out of the box #3

Closed
alex-taffe opened this issue Jan 29, 2021 · 7 comments
Closed

Can’t compile out of the box #3

alex-taffe opened this issue Jan 29, 2021 · 7 comments

Comments

@alex-taffe
Copy link

The SoundCloud library and StackNavigationView seem to not be committed to git. They should probably use the swift package manager instead. I can submit a PR for this, but wasnt sure if there was a reason why this was done this way

@lbrndnr
Copy link
Owner

lbrndnr commented Jan 29, 2021

Yeah you're right of course. The problem is that as far as I know, the swift package manager does not allow local repositories, at least not in a particularly useful way. This made it a bit difficult to work on these two frameworks.
I wasn't expecting anybody to contribute to Nuage this quickly so I guess I will add them again via the swift package manager :)

@alex-taffe
Copy link
Author

@lbrndnr You actually can. If you just drag the package folder into Xcode on the sidebar, it’ll add it as a local repo and it functions the same way as a remote one. Or just setup git submodules

@lbrndnr
Copy link
Owner

lbrndnr commented Jan 29, 2021

Gimme one sec, I have it fixed in a moment

lbrndnr added a commit that referenced this issue Jan 29, 2021
lbrndnr added a commit that referenced this issue Jan 29, 2021
@lbrndnr
Copy link
Owner

lbrndnr commented Jan 29, 2021

This should be working now. Let me know if you have any other issues :)

@swiatrzyk
Copy link

swiatrzyk commented May 3, 2024

@lbrndnr Can't compile for the same reason (missing SoundCloud framework) 😕

@lbrndnr
Copy link
Owner

lbrndnr commented May 3, 2024

@swiatrzyk you can use https://github.com/lbrndnr/nuage-macos to checkout SoundCloud framework as well. It's a git submodule :)

@swiatrzyk
Copy link

Thanks, problem solved 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants