Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/6/jeffreypicard/deployment with hub #8

Merged
merged 5 commits into from
Dec 10, 2021

Conversation

jeffreypicard
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Nov 12, 2021

Pull Request Test Coverage Report for Build 1563236234

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 413 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.1%) to 51.77%

Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.79%
claimtrie/node/node.go 3 64.32%
peer/peer.go 3 76.3%
btcjson/walletsvrcmds.go 8 96.09%
claimtrie/claimtrie.go 15 75.22%
rpcclaimtrie.go 18 0%
txscript/nameclaim.go 19 82.93%
lbcd.go 28 0%
mempool/mempool.go 65 66.75%
blockchain/chain.go 252 60.9%
Totals Coverage Status
Change from base Build 1446253617: 0.1%
Covered Lines: 22064
Relevant Lines: 42619

💛 - Coveralls

Much of these contriguration for specifically for running this on
linode.
@@ -0,0 +1,38 @@
# This Dockerfile builds btcd from source and creates a small (55 MB) docker container based on alpine linux.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/btcd/lbcd and s/Bitcoin/LBRY

@lbry-bot lbry-bot assigned jeffreypicard and unassigned roylee17 Nov 23, 2021

services:
lbcd:
image: jeffreypicard/lbcd:deployment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to use a pre-built image, or we can use the one built from Dockerfile.deploy?

Copy link
Collaborator

@roylee17 roylee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Linode experience, but this is a good initiative.
Other than some nitpicks, it looks good to me.

@kauffj kauffj merged commit 63c6edd into master Dec 10, 2021
@roylee17 roylee17 deleted the feature/6/jeffreypicard/deployment-with-hub branch December 27, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants