-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/6/jeffreypicard/deployment with hub #8
Conversation
Pull Request Test Coverage Report for Build 1563236234
💛 - Coveralls |
Much of these contriguration for specifically for running this on linode.
@@ -0,0 +1,38 @@ | |||
# This Dockerfile builds btcd from source and creates a small (55 MB) docker container based on alpine linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/btcd/lbcd
and s/Bitcoin/LBRY
contrib/linode/docker-compose.yml
Outdated
|
||
services: | ||
lbcd: | ||
image: jeffreypicard/lbcd:deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to use a pre-built image, or we can use the one built from Dockerfile.deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have Linode experience, but this is a good initiative.
Other than some nitpicks, it looks good to me.
No description provided.