Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass permanent URL to analytics event / output issue #1494

Closed
tzarebczan opened this issue May 18, 2018 · 0 comments
Closed

Pass permanent URL to analytics event / output issue #1494

tzarebczan opened this issue May 18, 2018 · 0 comments
Labels
area: internal type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

The Issue

https://github.com/lbryio/lbry-app/blob/master/src/renderer/redux/actions/content.js#L228

Instead of passing the current uri the user is on, which could be the vanity uri or a variation with/without the channel, we should determine and pass the permanent uri as specified in the claim metadata.

I also noticed that the outpoint is being filled sporadically, not sure exactly why that is. Maybe it's supposed to pass streamInfo.outpoint and not streamInfo.output ? But that wouldn't explain why it's working sometimes.

System Configuration

  • LBRY Daemon version:
  • LBRY App version:
  • LBRY Installation ID:
  • Operating system:

Anything Else

Screenshots

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed area: internal labels May 18, 2018
@tzarebczan tzarebczan changed the title Pass permanent URL to analytics event Pass permanent URL to analytics event / output issue Jun 5, 2018
@neb-b neb-b closed this as completed Jun 6, 2018
jessopb pushed a commit that referenced this issue Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: internal type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

3 participants