Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it Easy For People to Find Their Log #1556

Closed
Invariant-Change opened this Issue Jun 6, 2018 · 13 comments

Comments

Projects
None yet
6 participants
@Invariant-Change
Copy link
Contributor

Invariant-Change commented Jun 6, 2018

Add a button to auto open log or log folder or both, so that users can send debugging information easier.

image

@seanyesmunt

This comment has been minimized.

Copy link
Member

seanyesmunt commented Jun 6, 2018

I really like this idea.

@Invariant-Change

This comment has been minimized.

Copy link
Contributor Author

Invariant-Change commented Jun 6, 2018

Required Code

<div className="card__actions">
            <Button
              button="primary"
              label={__('Open Log File')}
              icon={icons.MESSAGE}
              href="{log-location}"
            />
          </div>

Code Location

Adjustments:

  • New/better icon.
  • Dynamic log location variable which always points to the correct location regardless of OS.
@kauffj

This comment has been minimized.

Copy link
Member

kauffj commented Jun 6, 2018

Agreed, this is a great idea @Invariant-Change!

The button should probably be somewhere else though. Either a standalone card, or in About?

@Invariant-Change

This comment has been minimized.

Copy link
Contributor Author

Invariant-Change commented Jun 6, 2018

As a separate section makes it easier to find. So I guess that is the best solution.

image

Or better still...

image

@amitnndn

This comment has been minimized.

Copy link
Contributor

amitnndn commented Jun 8, 2018

I will take this up!

I had a couple of questions/clarifications - @kauffj @seanyesmunt

  • The log files location are mentioned in this post and I am assuming that this is the right file.
  • I know that the electron shell plugin allows you to open external files that are on the file system, but it cannot open files with relative paths. Does anyone know how I can access properties like the user's home directory etc.?
@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 8, 2018

@amitnndn take a look at how we do this on the backup page: https://github.com/lbryio/lbry-app/blob/afaad1910e84d27140abaa696af53a985349c53d/src/renderer/page/backup/view.jsx

In this case, the setting is: data_dir

@amitnndn

This comment has been minimized.

Copy link
Contributor

amitnndn commented Jun 8, 2018

@tzarebczan Thank you! I will take a look at it.

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

amitnndn added a commit to amitnndn/lbry-app that referenced this issue Jun 9, 2018

@amitnndn

This comment has been minimized.

Copy link
Contributor

amitnndn commented Jun 16, 2018

#1600 I see that there is an issue opened, that is related to the changes in this issue. Can anybody with a Windows 10 system, click on the open log folder and let me know what folder it ends up opening? Thank you!

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 16, 2018

On windows 10 and Mac, it opens to the parent folder of lbrynet, with it highlighted. Think you want to pass the logfile and have it open that folder.

@amitnndn

This comment has been minimized.

Copy link
Contributor

amitnndn commented Jun 16, 2018

@tzarebczan Is that happening when you click on 'Open Log Folder' or 'Open Log'?

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 16, 2018

It's described in the issue. It happens when you click open log folder. Open log opens the logfile in notepad correctly.

@amitnndn

This comment has been minimized.

Copy link
Contributor

amitnndn commented Jun 16, 2018

Got it! 👍 A bit of a lag in my brain registering an Issue on a Friday night!!

@tzarebczan

This comment has been minimized.

Copy link
Member

tzarebczan commented Jun 16, 2018

Closing this, #1600 tracks latest issue.

@tzarebczan tzarebczan closed this Jun 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.