-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it Easy For People to Find Their Log #1556
Comments
I really like this idea. |
Required Code<div className="card__actions">
<Button
button="primary"
label={__('Open Log File')}
icon={icons.MESSAGE}
href="{log-location}"
/>
</div> Adjustments:
|
Agreed, this is a great idea @Invariant-Change! The button should probably be somewhere else though. Either a standalone card, or in About? |
I will take this up! I had a couple of questions/clarifications - @kauffj @seanyesmunt
|
@amitnndn take a look at how we do this on the backup page: https://github.com/lbryio/lbry-app/blob/afaad1910e84d27140abaa696af53a985349c53d/src/renderer/page/backup/view.jsx In this case, the setting is: |
@tzarebczan Thank you! I will take a look at it. |
#1600 I see that there is an issue opened, that is related to the changes in this issue. Can anybody with a Windows 10 system, click on the open log folder and let me know what folder it ends up opening? Thank you! |
On windows 10 and Mac, it opens to the parent folder of lbrynet, with it highlighted. Think you want to pass the logfile and have it open that folder. |
@tzarebczan Is that happening when you click on 'Open Log Folder' or 'Open Log'? |
It's described in the issue. It happens when you click open log folder. Open log opens the logfile in notepad correctly. |
Got it! 👍 A bit of a lag in my brain registering an Issue on a Friday night!! |
Closing this, #1600 tracks latest issue. |
Add a button to auto open log or log folder or both, so that users can send debugging information easier.
The text was updated successfully, but these errors were encountered: