Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force videojs-hls on apple browsers/devices #5323

Closed
tzarebczan opened this issue Jan 18, 2021 · 1 comment
Closed

force videojs-hls on apple browsers/devices #5323

tzarebczan opened this issue Jan 18, 2021 · 1 comment
Labels
type: bug Existing functionality is wrong or broken

Comments

@tzarebczan
Copy link
Contributor

Sean has the details on how to force. Need to make sure it doesn't break the video display when scrolling.

@tzarebczan tzarebczan added the type: bug Existing functionality is wrong or broken label Jan 18, 2021
@DispatchCommit
Copy link
Contributor

DispatchCommit commented Jan 20, 2021

Default behavior is to not override in safari (PR#843 video js: https://github.com/videojs/http-streaming/pull/843/files#diff-51ba21f30e4636f6d930df4888344453235c45c1c9f1e3f0adc2bc6bdfa5ccb4R879)

There's no need to always force a native override as Safari supports HLS streaming natively, bitwave uses:

overrideNative: !videojs.browser.IS_SAFARI

Though IS_ANY_SAFARI is recommended (and default behavior now).

The current usage of forcing to true is from an outdated recommendation here: videojs/http-streaming#168

which stemmed from this PR: videojs/video.js#5328

The reasoning for which to use is explained here: videojs/http-streaming#505

value should probably be: overrideNative: !videojs.browser.IS_ANY_SAFARI
since iOS/iPadOS devices have good HLS support (just like macOS). Using IS_SAFARI would make the exception only cover desktop.

we're likely going to use IS_ANY_SAFARI rather than IS_SAFARI as it covers more bases

TLDR:The value for overrideNative should be changed to !videojs.browser.IS_ANY_SAFARI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Existing functionality is wrong or broken
Projects
None yet
Development

No branches or pull requests

2 participants