Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default overrideNative to !videojs.browser.IS_SAFARI #505

Closed
marcelbeumer opened this issue May 10, 2019 · 5 comments
Closed

Default overrideNative to !videojs.browser.IS_SAFARI #505

marcelbeumer opened this issue May 10, 2019 · 5 comments
Milestone

Comments

@marcelbeumer
Copy link

marcelbeumer commented May 10, 2019

Description

Similar to #168, but instead of defaulting to true, I think overrideNative should default to !videojs.browser.IS_SAFARI, like done here:

overrideNative: !videojs.browser.IS_SAFARI

It would allow for a more consistent player experience out of the box. I found out about the overrideNative option after finding out Android/Chrome has issues not showing the loading/waiting indicator, first thinking I stumbled on a major vjs bug.

videojs-http-streaming version

what version of videojs-http-streaming does this occur with?
videojs-http-streaming 1.9.3

videojs version

what version of videojs does this occur with?
video.js 7.5.4

@welcome
Copy link

welcome bot commented May 10, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@wkoncki
Copy link

wkoncki commented Mar 4, 2020

@marcelbeumer
Just wanted to add the default value should probably be
overrideNative: !videojs.browser.IS_ANY_SAFARI
since iOS/iPadOS devices have good HLS support just like macOS ones. Using IS_SAFARI would make the exception only cover desktop.

@gkatsev
Copy link
Member

gkatsev commented Mar 31, 2020

yeah, we're likely going to use IS_ANY_SAFARI rather than IS_SAFARI as it covers more bases.

@gkatsev
Copy link
Member

gkatsev commented Jun 10, 2020

This has just been merged into master via #843.

@gkatsev gkatsev closed this as completed Jun 10, 2020
@phloxic
Copy link
Contributor

phloxic commented Oct 15, 2020

yeah, we're likely going to use IS_ANY_SAFARI rather than IS_SAFARI as it covers more bases.

@gkatsev - so e.g. Chrome on iOS does not have issues with vhs? So far I used !IS_ANY_SAFARI && !IS_IOS ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants