New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1698 #1727

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@tzarebczan
Member

tzarebczan commented Jul 3, 2018

After fixing the show error, I then received "this object has been destroyed already" if reopening too quickly. The 2nd commit fixes that. It just won't open if you try it too quickly (while LBRY is still shutting down) - not sure we can do much about that at without a larger refactor.

tzarebczan added some commits Jul 3, 2018

null rendererwindow window on quit
Checking to see if this fixes object has been destroyed error on Mac.

@tzarebczan tzarebczan requested a review from seanyesmunt Jul 3, 2018

@seanyesmunt seanyesmunt merged commit de5a76d into master Jul 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@seanyesmunt seanyesmunt deleted the fix-mac-undefined branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment