persists transaction filter: RE #1154 #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessopb
changed the title
jessopb
force-pushed
the
txListFilterPersist
branch
from
c926d3b
to
be237d6
Compare
neb-b
suggested changes
Oct 18, 2018
There was a problem hiding this comment.
Just the change to add an "all" transaction type. To have this properly persist you will need to add a new redux filter like this: https://github.com/lbryio/lbry-desktop/blob/master/src/renderer/store.js#L108
We only need to persist the filter setting from that reducer.
Other than that looks good! This will be great to have.
jessopb
force-pushed
the
txListFilterPersist
branch
from
be237d6
to
3b58914
Compare
neb-b
suggested changes
Oct 18, 2018
jessopb
force-pushed
the
txListFilterPersist
branch
from
3b58914
to
c74def2
Compare
neb-b
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: lbryio/lbry-redux#84
ISSUE: #1154
Filter choices in transaction list persist.