Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comic-book reader #2484

Merged
merged 9 commits into from May 24, 2019
Merged

Comic-book reader #2484

merged 9 commits into from May 24, 2019

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented May 16, 2019

WIP...

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #1377

What is the current behavior?

There is no viewer for comic book archives

What is the new behavior?

A simple viewer for comic book archives (CBR, CBT, CBZ, CB7)

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 16, 2019

I'm not sure if I should be adding this files inside the static folder:
https://github.com/lbryio/lbry-desktop/tree/comicbook-reader/static/webworkers

ES module and webworker bundle, ES module part is your interface to talk to library, use it like any other module, webworker bundle lives in libarchive.js/dist folder so you need to make sure that it is available in your public folder since it will not get bundled if you're using bundler (it's all bundled up already) and specify correct path to Archive.init() method

https://github.com/nika-begiashvili/libarchivejs#how-to-use

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 16, 2019

There still some work to do on the repo side: https://github.com/btzr-io/Villain

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 16, 2019

The viewer should also work on the website, but I'm not sure how to enable it yet 😛

@neb-b
Copy link

neb-b commented May 16, 2019

This is awesome! We still have to make some changes to handle viewing any non audio/video content on lbry.tv.

Why does this need a webworker?

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 17, 2019

@seanyesmunt The worker is required by libarchivejs and it's for the extraction process (decompression of the archive)
https://github.com/btzr-io/Villain#webworker

@neb-b
Copy link

neb-b commented May 20, 2019

@kauffj Do you know if could be any issues with adding this? https://github.com/nika-begiashvili/libarchivejs

@neb-b
Copy link

neb-b commented May 22, 2019

@btzr-io I think this is fine. Can you just add a comment above the static scripts that explains why they are there?

@kauffj
Copy link
Member

kauffj commented May 22, 2019

I only took a quick glance, but I don't see why we couldn't add libarchivejs. It's worth considering: 1) whether archive support should be added to the SDK and 2) how this will work on the web, but neither are blocking considerations.

@btzr-io
Copy link
Collaborator Author

btzr-io commented May 23, 2019

@seanyesmunt in this file ?

@neb-b neb-b merged commit d15a85e into master May 24, 2019
@neb-b neb-b deleted the comicbook-reader branch June 27, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants