add message to say content is hidden according to settings (2703) #3038
Conversation
There was a problem hiding this comment.
This is looking great! Just a couple small comments. Can you also add a changelog entry to this file?
https://github.com/lbryio/lbry-desktop/blob/master/CHANGELOG.md
| return ( | ||
| <div className="section--padded section__subtitle"> | ||
| <Icon icon={ICONS.EYE_OFF} /> | ||
| {__(' Content might be hidden on this ' + type + ' because of your ')} |
There was a problem hiding this comment.
Please change this to:
<I18nMessage tokens={{ type, settings: <Button button="link" label={__('settings')} href="/$/settings" /> }}>
Content may be hidden on this %type% because of your %settings%
</I18nMessage>
src/ui/component/claimList/view.jsx
Outdated
| @@ -92,6 +95,7 @@ export default function ClaimList(props: Props) { | |||
| <div className={classnames('claim-list__header', { 'claim-list__header--small': type === 'small' })}> | |||
| {header} | |||
| {loading && <Spinner type="small" />} | |||
| {obscureNsfw && <HiddenNsfw type="page" />} | |||
There was a problem hiding this comment.
I'm not sure this should live in this component. I don't think this should be shown on the home page or your list of publishes. Probably only in page/tags/view.jsx, maybe we could pass a prop down from there?
I like the styling on this though!
There was a problem hiding this comment.
Moved it to the tags view! Also I edited the icons .scss to give a little bit of space between the icon and the message which are mashed together now that its in the I18nMessage component.
Now this message should only appear when viewing tag results.
|
@tombiju thanks for the PR, your first! Can we show you some appreciation for the contribution? Also, we're giving away some Hacktoberfest bonuses and goodies for this month. We'll get it all figured out after you shoot us an email after this is reviewed/merged. |
|
@seanyesmunt @tombiju maybe we could brainstorm some other ways of displaying this? I think adding this is a definitely a valuable addition, but it is noisy to see this frequently if you are actively and purposefully blocking channels. I would be inclined to put it at the bottom of the results, but with infinite scroll this is tricky. If we cannot come up with a solution other than putting it in the top, I think we should reduce it to an icon with text on mouseover and/or make it collapsable to an icon so you don't have to keep seeing it. |
|
@kauffj This is only for viewing mature tag pages with the setting off. Blocked channels are completely hidden from the UI. @tombiju This is closer but we should only show this setting if you are on the tag page and it's a mature tag. We have a list of the current tags we track here: |
| @@ -109,6 +111,7 @@ function ClaimListDiscover(props: Props) { | |||
| (personalSort === SEARCH_SORT_CHANNELS && subscribedChannels.length) || | |||
| (personalSort === SEARCH_SORT_YOU && !!tags.length) || | |||
| personalSort === SEARCH_SORT_ALL; | |||
| const hasMatureTags = tags.some(t => MATURE_TAGS.includes(t)); | |||
There was a problem hiding this comment.
@seanyesmunt @kauffj Just added this in to see if the tag is mature, so the message will be shown accordingly and it shouldn't be too obtrusive anymore!
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: 2703 (#2703)
What is the current behavior?
What is the new behavior?
A message shows up in the UI near the top notifying the user that there settings might hide some content, and there is a link to go to the settings page and modify them.
Although the ticket only asked for mature tags, the message is not too much in the users face so I thought it would be good to have it in the landing discover page, during tag searches, and during regular text searches:
Other information