Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Forward and Backward Mouse Buttons #3763

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

dalhill
Copy link
Contributor

@dalhill dalhill commented Feb 28, 2020

PR Checklist

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

  • Bugfix

Fixes

Issue Number: #3744

What is the current behavior?

Forward and backward mouse buttons do not navigate history.

What is the new behavior?

Forward and backward mouse buttons should navigate history

Other information

I don't have forward and backward mouse buttons so I tested using the middle button and right click button. After testing I updated the buttons to properly reflect forward and backward. I'm using mozilla docs as a reference. If someone can test this, it would be much appreciated.

Note: I'm not sure what other functionality these buttons are supposed to provide. For example if they can be used to fast-forward or rewind a video, I do not know.

@neb-b neb-b merged commit 119bda8 into lbryio:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants