Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Logo Reloads At "/" #4031

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Header Logo Reloads At "/" #4031

merged 1 commit into from
Apr 21, 2020

Conversation

harshkhandeparkar
Copy link
Contributor

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

  • Clicking the header logo will refresh the page if location is /, otherwise, redirect to /.

Issue Number: #3710

What is the current behavior?

  • Header logo redirects to / if the location is not / and scrolls to the top of the page.

What is the new behavior?

  • Header logo refreshes the page if the location is /, otherwise, redirect to /.
    header-reload-lbry

Other information

@tzarebczan
Copy link
Contributor

Congrats on your first PR! We'll get this reviewed soon. Can we show you some appreciation for the contribution?

Also, please consider signing up for our dev mailing list at the bottom of https://lbry.tech!

@harshkhandeparkar
Copy link
Contributor Author

Thank you!

@neb-b neb-b self-requested a review April 21, 2020 21:12
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Apr 21, 2020
@lbry-bot lbry-bot assigned neb-b and unassigned neb-b Apr 21, 2020
@neb-b
Copy link

neb-b commented Apr 21, 2020

Works great!

@neb-b neb-b merged commit 5b58a46 into lbryio:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants