Pause 'Autoplay' when scrolled off screen. #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #-4021. ## Changes: When the autoplay overlay gets partially off-screen, the timer will be stopped. We can tweak how much down it needs to be scrolled. When timer is paused, the countdown resets. The pausing mechanism has no effect on the floating player (since the 'top' can never go negative). This behavior is the same as another big video platform.
infinite-persistence
force-pushed
the
pause-autoplay-when-offscreen
branch
from
b0bc352
to
7edb844
Compare
neb-b
reviewed
Jun 23, 2020
1. Use a constant for the classname instead of being hardcoded. 2. Use existing 'debounce' function instead of introducing another. 3. Added changelog entry.
infinite-persistence
force-pushed
the
pause-autoplay-when-offscreen
branch
from
7edb844
to
f36be20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Don't Allow Autoplay when commenting / taking other actionsChanges
Modalis present.Aside
0.46.2: I noticed that with the first video viewed from a fresh session, the timer takes a while to appear. (Update: seems like just need to scroll down for "Related"to load at least once).