Fix: Videos start muted on initial session #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Issue 4831: Videos start muted on Desktop (fresh install) and web (sometimes resets) This covers the Desktop fresh install and Web fresh session (incognito) part. It doesn't cover the "sometimes reset" part as I don't know how to reproduce that. ## Change `sessionStorage` is always empty when that piece of code is called, even for non-fresh Desktop and even in Brave. We now fallback to `1` when `volume` is `null`. Still not sure the purpose of that code, but leaving it there just in case something relies on it. ## Tests [/] Desktop fresh-install is not muted. [/] Desktop return session restores previous volume level. [/] Web* fresh session (cleared data) is not muted. [/] Web return session restores previous volume level. *Web = Chrome, Firefox and Brave.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4831: Videos start muted on Desktop (fresh install) and web (sometimes resets)
This covers the Desktop fresh install and Web fresh session (incognito) part.
It doesn't cover the "sometimes reset" part -- not sure how to reproduce that.
Change
sessionStorageis always empty when that piece of code is called, even for non-fresh Desktop and even in Brave.localStoragedoesn't have avolumeentry either.We now fallback to
1whenvolumeisnull. Still not sure the purpose of that code, but leaving it there just in case something relies on it.Tests
[/] Desktop fresh-install is not muted.
[/] Desktop return session restores previous volume level.
[/] Web* fresh session (cleared data) is not muted.
[/] Web return session restores previous volume level.
*Web = Chrome, Firefox and Brave.