Zoomable image viewer in Markdown (posts and comments) #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neb-b
reviewed
Jan 26, 2021
neb-b
reviewed
Jan 26, 2021
infinite-persistence
force-pushed
the
ip-image-viewer
branch
from
e78e05b
to
0817cb8
Compare
|
|
| @@ -128,6 +128,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| .img__zoomable { | |||
| cursor: pointer; // 'zoom-in' would be ideal, but browser-dependant. | |||
There was a problem hiding this comment.
This could be solved down the road by adding a hover overlay to the image that indicates zoom-in.
https://stackoverflow.com/questions/21086385/how-to-make-in-css-an-overlay-over-an-image
DispatchCommit
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
There may be some unintended behavior when an image is also used as a link: https://lbry.tv/@dispatch:5/markdown-tests:6
When you click the image, the link will open in a new tab, but when you return to the tab, the image is also expanded in the modal window. This could be resolved or improved at a later time though.
But overall, a very nice feature / improvement.
## Issue 4899: Ability to expand images in markdown posts for viewing
infinite-persistence
force-pushed
the
ip-image-viewer
branch
from
0817cb8
to
25f0e85
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4899: Ability to expand images in markdown posts for viewing
Questionable
window.app.store.dispatchandimport { doOpenModal } from 'redux/actions/app';in a jsx file.Demo
p/s: Thanks to
btzr-iofor some pointers.