Comments Pagination

[infinite-persistence]

Status

• Test instance: https://kp.odysee.com
• Good to go when we get Tom's seal of approval.
  • While I've tested a lot, it's still a big change (affected many files), so a second look by someone else will be good before we deploy

Known issues

• Livestream remains unpaginated. Wait for Cursor Pagination in v3.
• Pinned comments is broken. Fixed
• Linked comments doesn't work right if nested or yet to be fetched. Fixed
  • The existing version suffers the same problem too (see Links to comments don't always work #5161).

Rough summary of changes

• Top level comments are paginated using infinite-scroll style.
• Replies are paginated using a "Show more" button.
• The existing "expand all replies" behavior is possible, but disabled for now, except for linked-comments.
• Reactions: now paginated as well, instead of always re-fetching for the entire list of comments.
  • When switching active channels, you might see like-counts temporarily reset if the fetch is slow.

Issue

Closes #6158 - Support Comment Pagination

[tzarebczan]

https://kp.odysee.com/@Odysee:8?view=discussion is a good large discussion to test on. Some findings:

1. When on large monitor, it shows a couple comments and the loading icon, but not actually loading anything:
   

2. this shows 2 replies, but there's only 1. When you expand, you see the 1 + loading icon:
   

Other feedback
It's annoying to scroll in large lists like above, especially when you do it quickly - it seems like it only loads a few things, and then keeps showing loading icon for more. Scrolling slower seems to fair better.

Seems pretty solid otherwise, even on mobile!

[infinite-persistence]

Update

6c80acd to 4731588

• Tell user when linked-comment is not available.
• Load comments if spinner is visible from the start (it was previously only responding to scroll events)
• Load comments when approaching viewport
  • This approach works, but currently, the issue in 6473 negates the effect at times.
• Bumped comment and reply page size to 10 (was 5 and 3, respectively)

Test instance updated as well.

Pending

this shows 2 replies, but there's only 1. When you expand, you see the 1 + loading icon:

Asking Mark if it's possible for replies to reflect the final listing.