Open in desktop

[btzr-io]

PR Checklist

Please check all that apply to this PR using "x":

• I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
• I added a line describing my change to CHANGELOG.md
• I have checked that this PR does not introduce a breaking change
• This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting)
• Refactoring (no functional changes)
• Documentation changes
• Other - Please describe:

Fixes

Issue Number: #6703, #6659
Changelog update: #6735

Web -> Desktop

[kauffj]

I like the intent of this but we're trying to keep Odysee and LBRY Desktop strongly separated. Please discuss with me over chat.

[kauffj]

Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY.

[btzr-io]

Odysee apps can know about Odysee other apps. LBRY cannot know about Odysee. Odysee can know about LBRY URLs, so this may be a way to facilitate Odysee -> LBRY.

I'll remove the 'Open in web' button.

[btzr-io]

@kauffj When I open an external 'lbry://' link on the browser, the desktop app doesn't resolve it. This PR also fixes that bug.

[btzr-io]

Changelog update: #6735

[btzr-io]

Can someone test or review this ?

[roylee17]

Can someone test or review this ?

Thanks for your contribution.
I'd recommend @jessopb for reviewing.

[kauffj]

The code looks fine but I still have concerns about introducing this element on Odysee, where many users will not have LBRY Desktop.

What's the UX like when the user does not have the desktop app installed? Is there a way we can explain to those users what this feature does?

[btzr-io]

What's the UX like when the user does not have the desktop app installed?

I think is ignored if there is no protocol handler registered.

[btzr-io]

What's the UX like when the user does not have the desktop app installed?

Here are some initial ideas:

• Show a modal to inform the user about the desktop app
• Open a link ( on a new tab ) directly to the lbry website: https://lbry.com/get

[btzr-io]

A similar approach to spotify "Open in desktop" feature will be:

1. Try to open custom protocol link
2. Wait a few seconds then redirect to https://lbry.com/get

It will probably require a custom route or param for open.lbry.com:

https://open.lbry.com/desktop/{LBRY_URI}
https://open.lbry.com/{LBRY_URI}?desktop=true

[btzr-io]

This requires more additional work, I removed all the UI changes #6779

[Snake883]

This half way works. I'll explain...

I want the LBRY Desktop app to accept a parameter for a link, and go to the link.

Functionality

Function 1: Protocol ("LBRY://")

In Windows Run, I want the associated program to open the link:

Function 2: LBRY.exe Parameter ("c:\program files\LBRY\LBRY.exe %1")

Functional Test 1

LBRY Desktop running.

Test 1A

Failed test.
In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link.

Test 1B

In both functions, LBRY Desktop receives focus. But, LBRY Desktop does not go to the link.

Functional Test 2

LBRY Desktop not running.

Test 2A

Passed test.
In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link.

Test 2B

Passed test.
In both functions, LBRY Desktop receives focus and LBRY Desktop goes to the link.

[btzr-io]

@snakyjake1 Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ?

[Snake883]

Did you try https://github.com/lbryio/lbry-desktop/releases/tag/untagged-aa3ae8f9162b42aace2a ?

@btzr-io I couldn't get your link to work.

[btzr-io]

@snakyjake1 Whats your current desktop version ? Where Test 1A, Test 1B run using v0.51.0-rc.2 ?

[Snake883]

Whats your current desktop version?

Both tests on v0.51.1.