Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix desktop deep links handler #6779

Merged
merged 2 commits into from Aug 4, 2021
Merged

Fix desktop deep links handler #6779

merged 2 commits into from Aug 4, 2021

Conversation

btzr-io
Copy link
Collaborator

@btzr-io btzr-io commented Aug 4, 2021

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #6703

@btzr-io btzr-io linked an issue Aug 4, 2021 that may be closed by this pull request
@btzr-io btzr-io mentioned this pull request Aug 4, 2021
10 tasks
@btzr-io
Copy link
Collaborator Author

btzr-io commented Aug 4, 2021

I only tested this on windows. This requires additional testing to ensure is working on other platforms (macOS, linux)

@tzarebczan
Copy link
Contributor

Thanks for this! You know the drill.

Will have @keikari try it out on Linux and I can test Mac in my VM.

@tzarebczan tzarebczan merged commit 8a89645 into master Aug 4, 2021
@tzarebczan tzarebczan deleted the fix-desktop-deep-links branch August 4, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop app fails to resolve external protocol links (lbry://)
2 participants