Use resolve for OG metadata #6787

btzr-io · 2021-08-05T05:42:44Z

PR Checklist

Please check all that apply to this PR using "x":

I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
I added a line describing my change to CHANGELOG.md
I have checked that this PR does not introduce a breaking change
This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

Fixes

Closes #6780
Closes #6464
Closes #6812

btzr-io · 2021-08-05T05:51:01Z

I'm still not sure how to test this...

infinite-persistence · 2021-08-05T06:08:14Z

yarn && yarn dev:web-server
localhost:1337 in the browser after build is done.
Open a content page, then F5 to reload (or enter URL directly). The OG is not populated on link navigation.
Verify the <head> for the OG and GoogleVideo info

btzr-io · 2021-08-05T06:30:43Z

* `yarn && yarn dev:web-server`

* `localhost:1337` in the browser after build is done.

* Open a content page, then F5 to reload (or enter URL directly).  The OG is not populated on link navigation.

* Verify the `<head>` for the OG and GoogleVideo info
  
  * <img alt="" width="400" src="https://user-images.githubusercontent.com/64950861/128299681-e2f50acd-2d37-483f-8ca1-979feb89f810.png">

Nice thanks ✌️

web/src/html.js

infinite-persistence · 2021-08-06T00:31:51Z

web/src/html.js

+  const thumbnail = value && value.thumbnail && value.thumbnail.url;
+  const mediaType = source && source.media_type;
+  const mediaDuration = media && media.duration;
+  const creationTimestamp = meta && (meta.creation_timestamp || 0);


Should do value.release_time --> creation time --> 0. We've been using release time, which works for newer claims.

infinite-persistence · 2021-08-06T01:14:02Z

Nice, seems like "keyword"/tags now work too. I'm guessing CQ wasn't returning tags all this while.
Channel Page info is better now too. Previously, the link is totally wrong.
- -->

infinite-persistence · 2021-08-06T01:33:35Z

CHANGELOG.md

@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Improve twitter share _community pr!_ ([#6690](https://github.com/lbryio/lbry-desktop/pull/6690))
 - Update lighthouse search api _community pr!_ ([#6731](https://github.com/lbryio/lbry-desktop/pull/6731))
 - Update sockety api _community pr!_ ([#6747](https://github.com/lbryio/lbry-desktop/pull/6747))
+- Use resolve for OG metadata instead of chainquery _community pr!_ ([#6787](https://github.com/lbryio/lbry-desktop/pull/6787))


Not sure where the error is, but Embed OG's aren't showing up (it's showing the fallback).
Example embed: https://odysee.com/$/embed/eevblog-1412-argon-ion-laser-teardown!/1fe325659bf8d791f72e02bb614a942fa4b571bf?r=5yqd2A3cQ59DhkNRYTJq3BApzdcr7KSn

The embed url doesn't use : or # to separate the id.

Adding this .replace('\/', '#'); fixes the issue. Not sure if this will work on all cases.

As long as embed url is always $/embed/name/id ^^

btzr-io · 2021-08-06T06:29:50Z

Is there any other urls that uses / instead of : or # before the claim id ?

infinite-persistence · 2021-08-07T03:24:18Z

Is there any other urls that uses / instead of : or # before the claim id ?

Tom mentioned that anywhere we use generateStreamURL, generateDownloadUrl and generateDirectUrl. But those doesn't impact the header, I think.

However, I noticed that http://odysee.com/eevblog-1412-argon-ion-laser-teardown!/1fe325659bf8d791f72e02bb614a942fa4b571bf redirects and shows the right header, but the PR version does not.

btzr-io · 2021-08-07T03:43:09Z

However, I noticed that http://odysee.com/eevblog-1412-argon-ion-laser-teardown!/1fe325659bf8d791f72e02bb614a942fa4b571bf redirects and shows the right header, but the PR version does not.

Same issue with embed urls. parseURI fails to detect the claim id, because there is no '#'

lbry-desktop/web/src/html.js

Line 246 in be4c75c

    
           const { isChannel, streamName, channelName, channelClaimId, streamClaimId } = parseURI(url);

btzr-io · 2021-08-07T04:16:30Z

http://odysee.com/eevblog-1412-argon-ion-laser-teardown!/1fe325659bf8d791f72e02bb614a942fa4b571bf

This is actually the equivalent of:

lbry://eevblog-1412-argon-ion-laser-teardown!

Instead of:

lbry://eevblog-1412-argon-ion-laser-teardown!#1fe325659bf8d791f72e02bb614a942fa4b571bf

See: #6812

btzr-io · 2021-08-07T07:17:10Z

However, I noticed that http://odysee.com/eevblog-1412-argon-ion-laser-teardown!/1fe325659bf8d791f72e02bb614a942fa4b571bf redirects and shows the right header, but the PR version does not.

I don't think the redirection issue has nothing todo with the changes on this pull request.

This was linked to issues Aug 5, 2021

GoogleVideo Metadata: "uploadDate" tag incorrect #6780

Closed

Use resolve for OG metadata instead of chainquery #6464

Closed

btzr-io commented Aug 5, 2021

View reviewed changes

web/src/html.js Outdated Show resolved Hide resolved

btzr-io requested a review from infinite-persistence August 5, 2021 18:35

lbry-bot assigned infinite-persistence Aug 5, 2021

btzr-io requested a review from jessopb August 5, 2021 18:55

lbry-bot assigned jessopb Aug 5, 2021

infinite-persistence reviewed Aug 6, 2021

View reviewed changes

lbry-bot unassigned infinite-persistence Aug 6, 2021

infinite-persistence reviewed Aug 6, 2021

View reviewed changes

btzr-io added 5 commits August 7, 2021 10:16

use resolve for og metadata

6d91d1c

use value.audio for google video metadata

45fcf0d

update changelog

67f956f

use value.release_time

722f933

fix embed claim url

2c812da

btzr-io mentioned this pull request Aug 7, 2021

Inconsistent url redirection on development mode #6812

Closed

btzr-io linked an issue Aug 7, 2021 that may be closed by this pull request

Inconsistent url redirection on development mode #6812

Closed

btzr-io added 2 commits August 7, 2021 19:23

use better resolve url

68e4684

fix redirection and normalization of claim urls

c85e448

infinite-persistence force-pushed the fix-og-meta branch from caeb7d2 to c85e448 Compare August 7, 2021 11:53

infinite-persistence merged commit b7cbbd0 into master Aug 7, 2021

infinite-persistence deleted the fix-og-meta branch August 7, 2021 11:53

btzr-io mentioned this pull request Aug 7, 2021

Embed shows wrong OG metadata #6814

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use resolve for OG metadata #6787

Use resolve for OG metadata #6787

btzr-io commented Aug 5, 2021 •

edited by infinite-persistence

Loading

btzr-io commented Aug 5, 2021

infinite-persistence commented Aug 5, 2021

btzr-io commented Aug 5, 2021

infinite-persistence Aug 6, 2021

infinite-persistence commented Aug 6, 2021 •

edited

Loading

infinite-persistence Aug 6, 2021 •

edited

Loading

btzr-io Aug 6, 2021

btzr-io Aug 6, 2021

btzr-io Aug 6, 2021

btzr-io commented Aug 6, 2021

infinite-persistence commented Aug 7, 2021 •

edited

Loading

btzr-io commented Aug 7, 2021 •

edited

Loading

btzr-io commented Aug 7, 2021 •

edited

Loading

btzr-io commented Aug 7, 2021

Use resolve for OG metadata #6787

Use resolve for OG metadata #6787

Conversation

btzr-io commented Aug 5, 2021 • edited by infinite-persistence Loading

PR Checklist

PR Type

Fixes

btzr-io commented Aug 5, 2021

infinite-persistence commented Aug 5, 2021

btzr-io commented Aug 5, 2021

infinite-persistence Aug 6, 2021

Choose a reason for hiding this comment

infinite-persistence commented Aug 6, 2021 • edited Loading

infinite-persistence Aug 6, 2021 • edited Loading

Choose a reason for hiding this comment

btzr-io Aug 6, 2021

Choose a reason for hiding this comment

btzr-io Aug 6, 2021

Choose a reason for hiding this comment

btzr-io Aug 6, 2021

Choose a reason for hiding this comment

btzr-io commented Aug 6, 2021

infinite-persistence commented Aug 7, 2021 • edited Loading

btzr-io commented Aug 7, 2021 • edited Loading

btzr-io commented Aug 7, 2021 • edited Loading

btzr-io commented Aug 7, 2021

btzr-io commented Aug 5, 2021 •

edited by infinite-persistence

Loading

infinite-persistence commented Aug 6, 2021 •

edited

Loading

infinite-persistence Aug 6, 2021 •

edited

Loading

infinite-persistence commented Aug 7, 2021 •

edited

Loading

btzr-io commented Aug 7, 2021 •

edited

Loading

btzr-io commented Aug 7, 2021 •

edited

Loading