Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Paid embed warning was showing lbry.tv #6819

Merged
merged 6 commits into from
Aug 13, 2021
Merged

Fix: Paid embed warning was showing lbry.tv #6819

merged 6 commits into from
Aug 13, 2021

Conversation

Eniamza
Copy link
Contributor

@Eniamza Eniamza commented Aug 8, 2021

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #6816

What is the current behavior?

Paid embed's redirection overlay says "Watch on lbry,tv"

What is the new behavior?

Paid embed's redirection overlay says "Watch on Odysee"

Other information

@jessopb
Copy link
Member

jessopb commented Aug 10, 2021

Nice, thakns.
Can we use SITE_NAME here? like this

title={title || __('Log in to %SITE_NAME% to earn rewards', { SITE_NAME })}

@Eniamza
Copy link
Contributor Author

Eniamza commented Aug 10, 2021

@jessopb Site title in action ༼ つ ◕_◕ ༽つ

@jessopb jessopb merged commit 7cf9cba into lbryio:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants