Add all sqlite coin chooser, enabled by setting coin_selection_strategy to sqlite
#2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackrobison
force-pushed
the
sqlite-coin-chooser
branch
6 times, most recently
from
c4736c4
to
2490cd8
Compare
jackrobison
force-pushed
the
sqlite-coin-chooser
branch
from
775074f
to
70464a2
Compare
eukreign
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
This will take too long to review thoroughly: if the PR fixes a problem and the tests pass we can merge it. The long term solution is to implement a coin chooser in PL/SQL to match behavior of the existing branching selection algorithm; that will have to wait until after the postgresql refactor. This PR may be a great interim solution!
|
This also does not take into account unconfirmed utxos (even though the commit says so!) |
|
If there are concerns about this selection algorithm not being as complete as the others then perhaps it should not be the default and it can then be explicitly configured in cases where performance is slow? |
eukreign
requested changes
Jun 1, 2020
jackrobison
force-pushed
the
sqlite-coin-chooser
branch
2 times, most recently
from
28e57ee
to
6ccdf52
Compare
jackrobison
force-pushed
the
sqlite-coin-chooser
branch
from
6ccdf52
to
872b89e
Compare
eukreign
approved these changes
Jun 8, 2020
jackrobison
force-pushed
the
sqlite-coin-chooser
branch
from
0b74e96
to
bc9f33c
Compare
jackrobison
added
area: wallet
type: new feature
jackrobison
changed the title
sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.