-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all sqlite coin chooser, enabled by setting coin_selection_strategy to sqlite
#2959
Conversation
c4736c4
to
2490cd8
Compare
775074f
to
70464a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will take too long to review thoroughly: if the PR fixes a problem and the tests pass we can merge it. The long term solution is to implement a coin chooser in PL/SQL to match behavior of the existing branching selection algorithm; that will have to wait until after the postgresql refactor. This PR may be a great interim solution!
This also does not take into account unconfirmed utxos (even though the commit says so!) |
If there are concerns about this selection algorithm not being as complete as the others then perhaps it should not be the default and it can then be explicitly configured in cases where performance is slow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion: this should not be the default coin chooser.
28e57ee
to
6ccdf52
Compare
6ccdf52
to
872b89e
Compare
0b74e96
to
bc9f33c
Compare
sqlite
No description provided.