Bump to Python 3.9 attempt 3. #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tasks() wait for file_output_task completion. This fixes a problem with test_download_stop_resume_delete.
…ficant functional change here is in upload_to_reflector(). Unit tests in TestReflector were failing. Deal with lint related to CancelledError cleanup.
control order of events in test. While file_manager is stopped, we get no response to file_list().
…bjects to asyncio.wait() is deprecated since Python 3.8.
Code to handle CancelledError (as subclass of Exception) was removed.
This reverts commit 8def4d5.
|
Based on review comment from @jackrobison, I bumped the python_requires to >= 3.8 as that is when Tests passed on 3.8, so I chose python_requires>=3.8. But the goal is to build and deploy a version that uses 3.9. |
|
@moodyjon is this still being worked on or did the SEC decision cease the project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a further simplified version of #3623.
Recent test fixes and hub fixes have enabled me to drop the test hacks (i.e. asyncio.sleep) and get a pretty high passing rate. I have 10 passing runs so far (and 10 more queued):
https://github.com/moodyjon/lbry-sdk/actions/runs/3515646843
https://github.com/moodyjon/lbry-sdk/actions/runs/3516711314
https://github.com/moodyjon/lbry-sdk/actions/runs/3516712259
https://github.com/moodyjon/lbry-sdk/actions/runs/3516713098
https://github.com/moodyjon/lbry-sdk/actions/runs/3516714041
...etc
The changes related to stream_manager.py, file_manager.py, torrent_manager.py, managed_stream.py, test_streaming.py, test_stream_manager.py were STILL necessary. Timing of some things has changed specifically due to the python 3.9 upgrade, and the tests became unreliable with python 3.9. The changes make various stop() methods synchronous -- they cancel subtasks and WAIT on them to finish now. I also have some failing results with these changes removed:
https://github.com/moodyjon/lbry-sdk/actions/runs/3517690064
https://github.com/moodyjon/lbry-sdk/actions/runs/3517752779
https://github.com/moodyjon/lbry-sdk/actions/runs/3517753652