-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Python 3.9 attempt 3. #3711
Conversation
…tasks() wait for file_output_task completion. This fixes a problem with test_download_stop_resume_delete.
…ficant functional change here is in upload_to_reflector(). Unit tests in TestReflector were failing. Deal with lint related to CancelledError cleanup.
control order of events in test. While file_manager is stopped, we get no response to file_list().
…bjects to asyncio.wait() is deprecated since Python 3.8.
Code to handle CancelledError (as subclass of Exception) was removed.
This reverts commit 8def4d5.
Based on review comment from @jackrobison, I bumped the python_requires to >= 3.8 as that is when Tests passed on 3.8, so I chose python_requires>=3.8. But the goal is to build and deploy a version that uses 3.9. |
@moodyjon is this still being worked on or did the SEC decision cease the project? |
This is a further simplified version of #3623.
Recent test fixes and hub fixes have enabled me to drop the test hacks (i.e. asyncio.sleep) and get a pretty high passing rate. I have 10 passing runs so far (and 10 more queued):
https://github.com/moodyjon/lbry-sdk/actions/runs/3515646843
https://github.com/moodyjon/lbry-sdk/actions/runs/3516711314
https://github.com/moodyjon/lbry-sdk/actions/runs/3516712259
https://github.com/moodyjon/lbry-sdk/actions/runs/3516713098
https://github.com/moodyjon/lbry-sdk/actions/runs/3516714041
...etc
The changes related to stream_manager.py, file_manager.py, torrent_manager.py, managed_stream.py, test_streaming.py, test_stream_manager.py were STILL necessary. Timing of some things has changed specifically due to the python 3.9 upgrade, and the tests became unreliable with python 3.9. The changes make various stop() methods synchronous -- they cancel subtasks and WAIT on them to finish now. I also have some failing results with these changes removed:
https://github.com/moodyjon/lbry-sdk/actions/runs/3517690064
https://github.com/moodyjon/lbry-sdk/actions/runs/3517752779
https://github.com/moodyjon/lbry-sdk/actions/runs/3517753652